Openkore.com

OpenKore Forums
It is currently 22 Oct 2017, 13:19

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 42 posts ]  Go to page Previous  1, 2, 3, 4, 5  Next

Are you excited?
Git ROCKS! 68%  68%  [ 23 ]
SVN is the BEST!!! 15%  15%  [ 5 ]
Meh 9%  9%  [ 3 ]
About time... 9%  9%  [ 3 ]
Total votes : 34
Author Message
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 10:12 
Offline
Developers
Developers

Joined: 27 Feb 2012, 12:50
Posts: 45
By the way, hopefully you've seen our discussion about the new code review process: https://github.com/OpenKore/openkore/issues/9 :)

_________________
Tired of waiting for answers on the forums?
Want to talk to OpenKore experts?

Hang out on the #OpenKore IRC!


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 10:46 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
sofax222 wrote:
Commit failed (details follow):
Access to '/OpenKore/openkore/!svn/act/a3b50695-c1dd-e647-b25c-05daf3acf7df'
forbidden


How can I be added into the members of Github/Openkore ??


Well, I'll need to know what your github account is. I tried "sofax222" and "sofax" but it wasn't either of those :(

Once we have your username, any of the project admins can add you as a developer to the project. But you don't even need to be an official developer to the project to contribute on GitHub. Anyone can make a fork of the project in their own account, make commits, and then submit a pull request to be approved in the official repo.

Edit: I've updated my original post to be more clear. Hope that helps /no1


My github account is "snop222" !!


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 11:00 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
sofax222 wrote:
Commit failed (details follow):
Access to '/OpenKore/openkore/!svn/act/a3b50695-c1dd-e647-b25c-05daf3acf7df'
forbidden


How can I be added into the members of Github/Openkore ??


Well, I'll need to know what your github account is. I tried "sofax222" and "sofax" but it wasn't either of those :(

Once we have your username, any of the project admins can add you as a developer to the project. But you don't even need to be an official developer to the project to contribute on GitHub. Anyone can make a fork of the project in their own account, make commits, and then submit a pull request to be approved in the official repo.

Edit: I've updated my original post to be more clear. Hope that helps /no1


Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 12:00 
Offline
Developers
Developers

Joined: 27 Feb 2012, 12:50
Posts: 45
sofax222 wrote:
Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?


Hey there, I checked out your changes and everything looks good. Your pull request was merged into the main project. :)

Also, I've added you to the GitHub organization as a developer, check your email for confirmation.

Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).

If you're still curious how someone would be able to checkout your forked code from the official project, they'd just have to make a local branch with your repo as the remote. This is explained on GitHub by follow these steps:

Image

_________________
Tired of waiting for answers on the forums?
Want to talk to OpenKore experts?

Hang out on the #OpenKore IRC!


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 20:10 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
sofax222 wrote:
Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?


Hey there, I checked out your changes and everything looks good. Your pull request was merged into the main project. :)

Also, I've added you to the GitHub organization as a developer, check your email for confirmation.

Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).

If you're still curious how someone would be able to checkout your forked code from the official project, they'd just have to make a local branch with your repo as the remote. This is explained on GitHub by follow these steps:

Image


Yes !! I Got it !!
Thank you very much !!

So now, I can directly commit to the the official project, can't I ?
But now I have not codes need to commit.
I will keep this in my mind for next committing !!
I still don't well understand the GitHub user interface, I will do more effort on it.
Thanks again !!

One more question.....
Just like you said "... to checkout your forked code from ..."
In other words, I can keep my own version with this fork without merging from the official project.
Is it true ?


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 22:01 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
sofax222 wrote:
Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?


Hey there, I checked out your changes and everything looks good. Your pull request was merged into the main project. :)

Also, I've added you to the GitHub organization as a developer, check your email for confirmation.

Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).


Some thing stranger ......
I found the revison number is different between my frok and the official repo !!
Is it normal ??


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 04 Mar 2016, 22:49 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).

If you're still curious how someone would be able to checkout your forked code from the official project, they'd just have to make a local branch with your repo as the remote. This is explained on GitHub by follow these steps:

Image


Sorry, question again....
I work around on my fork of Openkore.....
But I can not find the "Merge pull request" function as your captured image, where is it ??


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 05 Mar 2016, 00:08 
Offline
Developers
Developers

Joined: 27 Feb 2012, 12:50
Posts: 45
sofax222 wrote:
Sorry, question again....
I work around on my fork of Openkore.....
But I can not find the "Merge pull request" function as your captured image, where is it ??


You'll probably want to spend some time learning how git works, there are a lot of great resources out there including the official Git documentation and YouTube tutorials. I sent you that screenshot because it explains the steps required for someone to take the master openkore branch and apply your patch for testing.

Earlier today you merged two pull requests:

https://github.com/OpenKore/openkore/pull/34
https://github.com/OpenKore/openkore/pull/35

Did you test these changes in game before merging them? The point of making pull requests is so that developers can review and test changes before they are incorporated into the main project.

_________________
Tired of waiting for answers on the forums?
Want to talk to OpenKore experts?

Hang out on the #OpenKore IRC!


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 05 Mar 2016, 02:29 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
Earlier today you merged two pull requests:

https://github.com/OpenKore/openkore/pull/34
https://github.com/OpenKore/openkore/pull/35

Did you test these changes in game before merging them? The point of making pull requests is so that developers can review and test changes before they are incorporated into the main project.


Ah, Sorry !! Very Sorry !! I think I had a mistake !!
I make wrong merging on main project !!
Could it to be rollbacked ??

I just want to try the "Merge Pull Request".
I will be more careful, before I well understnad the GitHub works !!
Sorry, again !!

PS: I think, I do only one "Merge", but merging two "Pull Request" !!


Top
 Profile  
 
 Post subject: Re: Moving to GitHub
PostPosted: 06 Mar 2016, 05:52 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
itsrachelfish wrote:
Did you test these changes in game before merging them? The point of making pull requests is so that developers can review and test changes before they are incorporated into the main project.


Dear itsrachelfish:

Now, am I a member of the Developers team in the OpenKore organization ??
Will the changes of main OpenKore repo automaticly to merge into my fork ??


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 42 posts ]  Go to page Previous  1, 2, 3, 4, 5  Next

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group