Auto marco not triggering macro?

All about the macro plugin can be found in this forum. This forum is intended for the macro plugin only.

Moderator: Moderators

Message
Author
ScriptKiddy
Noob
Noob
Posts: 16
Joined: 12 Aug 2017, 06:07
Noob?: No

Auto marco not triggering macro?

#1 Post by ScriptKiddy »

Hey guys. So through checking out this forum i found multiple threads with macros written, and explanations on, how to setup macros for getting, and then turning in board quests.

It took awhile to get it to actually except my macro file without spitting error codes, and i thought yay its done! But, im having trouble getting it to actually call the turn in macro by itself.

Basically when my quests are complete, it keeps saying "automacro "name" triggered" but it does not follow the steps of the macro to turn in it. HOWEVER, if i manually type in the console "macro "name"" it works perfectly, it follows the macro commands.

So I am having trouble figuring out how to get it to do it automatically when the quests are completed. I've tried changing a few parameters in the auto macro but it either breaks the macro complete (spitting out yellow error codes) or it has no effect what so ever.

Please see below for my macro and any help would be greatly appreciated.



-----------



automacro boardQuest {
timeout 60
exclusive 1
call {
$temp1 = @eval($::questList->{62750}->{missions}->{1133}->{count}+$::questList->{62751}->{missions}->{1134}->{count}+$::questList->{62753}->{missions}->{1282}->{count}+$::questList->{62752}->{missions}->{1135}->{count})
if ($temp1 >= 600) call boardQuest
}
}

macro boardQuest {
do ai manual
pause 2
do is Butterfly Wing
pause 5
do move lighthalzen 192 159
pause 15
do talknpc 192 161 c c r1 c r1 c c r0 n
pause 2
do talknpc 192 161 c c r0 c r4 n
do ai on
}

Mortimal
Developers
Developers
Posts: 389
Joined: 01 Nov 2008, 15:31
Noob?: No

Re: Auto marco not triggering macro?

#2 Post by Mortimal »

Code: Select all

automacro boardQuest {
eval (($::questList->{62750}->{missions}->{1133}->{count} + $::questList->{62751}->{missions}->{1134}->{count} + $::questList->{62753}->{missions}->{1282}->{count} + $::questList->{62752}->{missions}->{1135}->{count}) >= 600)
exclusive 1
call boardQuestM
}

macro boardQuestM {
do ai manual
pause 2
do is Butterfly Wing
pause 5
do move lighthalzen 192 159
pause 15
do talknpc 192 161 c c r1 c r1 c c r0 n
pause 2
do talknpc 192 161 c c r0 c r4 n
do ai on
}
Don't name macro and automacro the same, dont use call{ } construction it is buggy.
Please use pin function for uploading your file contents!

ScriptKiddy
Noob
Noob
Posts: 16
Joined: 12 Aug 2017, 06:07
Noob?: No

Re: Auto marco not triggering macro?

#3 Post by ScriptKiddy »

When i type "quest list" in the console it can clearly tell the quests are 150/150, but it does not trigger the macro turn in. I tried lowering the auto macro to temp1 >= 150 but even that didnt work!

But as soon as i type in "macro boardQuest" in the console it works perfectly. it just wont do it automatically. see below:



----------------------



quest list
--------------------------------- Quest List ----------------------------------
0 62750 Bounty Board Axe Kobold active
- 0
- Axe Kobold 150/150
1 2298 Adventurer's Companion inactive
2 62602 Bounty Board Luciola Vespa inactive
- Luciola Vespa 0/150
3 62751 Bounty Board Hammer Kobold active
- Hammer Kobold 150/150
- 0
4 62599 Bounty Board Cornus inactive
- Cornus 0/150
5 12056 Job Quest - Assassin inactive
6 3046 Sealed Shrine After-effect inactive Sun Jan 25 06:29:20 2015
7 5157 Enchant tutorial (1) inactive
8 106 Find The Heaviest Things in Mid inactive
9 8001 Job Change to Assassin inactive
10 60539 Ancient Mimic Hunting inactive
- Ancient Mimic 35/400
11 62808 Bounty Board Nepenthes inactive
- Nepenthes 19/150
12 60819 Hunting Daily Timer inactive Sat Apr 4 00:29:10 2015
13 62542 Adventurer's Guild Hunt inactive
- Pinguicula 0/100
14 62543 Adventurer's Guild Hunt inactive
- Dark Pinguicula 0/100
15 2299 Rapid Completion Experience inactive
16 60527 Purple Venatu Hunting inactive
- Purple Venatu 81/400
17 62807 Bounty Board Dark Pinguicula inactive
- Dark Pinguicula 0/150
18 8005 Job Change to Assassin inactive
19 60831 Abysmal Knight Hunting inactive
- Abysmal Knight 36/400
20 62753 Bounty Board Kobold Archer active
- 0
- Kobold Archer 150/150
21 62806 Bounty Board Pinguicula inactive
- Pinguicula 0/150
22 3045 Sealed Shrine inactive Sat Jan 24 21:29:20 2015
23 62752 Bounty Board Mace Kobold active
- 0
- Mace Kobold 150/150
24 62600 Bounty Board Naga inactive
- Naga 0/150
25 62529 Adventurer's Guild Hunt inactive
- Bradium Golem 26/100
26 62540 Adventurer's Guild Hunt inactive
- Nepenthes 19/100
-------------------------------------------------------------------------------
[macro] automacro boardQuest triggered.
[macro] automacro boardQuest triggered.
[macro] automacro boardQuest triggered.
You are now attacking Monster Axe Kobold (2)
[ 51/ 4] Monster Axe Kobold (2) attacks you (Dmg: Miss!) (Delay: 528ms)
[ 51/ 4] You attack Monster Axe Kobold (2) (Dmg: 870! + 182) (Delay: 170ms)



----------------------



doesnt turn in the quests. but as SOON as i type in "macro boardQuest" in the console this happens: works as intended:



macro boardQuest
AI set to manual mode
Permitted to use Teleport (26), level 2
You used Item: Butterfly Wing (2) x 1 - 4 left
Inventory Item Removed: Butterfly Wing (2) x 1
You are casting Teleport on yourself (Delay: 0ms)
Calculating route to: Lightharlzen, the City-State of Prosperity(lighthalzen): 192, 159
Talking to NPC at (192, 161) using sequence: c c r1 c r1 c c r0 n
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: You've stumbled upon what appears to be a bulletin board with wanted ads.
Bounty Board 101-150#pa: Take a closer look?
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: There are many listings for monster hunting.
- Responses (Bounty Board 101-150#pa) --
# Response
0 Check bounty missions
1 Collect bounty rewards
2 Where do I go to hunt?
3 Search for other bounty hunters.
4 I want to QUIT hunting
5 Not interested.
6 Cancel Chat
----------------------------------------
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: You are ready to collect your bounty.
Bounty Board 101-150#pa: Which bounty do you want to collect?
- Responses (Bounty Board 101-150#pa) --
# Response
0 Collect 1 bounty
1 Collect ALL bounties
2 cancel
3 Cancel Chat
----------------------------------------
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: Oh you fancy yourself a good hunter eh?
Bounty Board 101-150#pa: Let me see if you've actually hunted all the monsters you said you would.
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: How will you distribute your newfound experience?
- Responses (Bounty Board 101-150#pa) --
# Response
0 Both Base and Job EXP
1 I want Base EXP only.
2 I want Job EXP only.
3 Cancel Chat
----------------------------------------
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: Here is your reward.
Quest: Bounty Board Axe Kobold (62750) has been deleted.
Quest: Bounty Board Hammer Kobold (62751) has been deleted.
Quest: Bounty Board Mace Kobold (62752) has been deleted.
Quest: Bounty Board Kobold Archer (62753) has been deleted.
You gained 150,000 zeny.
You have gained 607500/479812 (3.88%/2.95%) Exp
You have gained 607500/410062 (3.88%/2.52%) Exp
You have gained 607500/385312 (3.88%/2.37%) Exp
You have gained 607500/736875 (3.88%/4.54%) Exp
Item added to inventory: Eden Merit Badge (29) x 2 - Event
NPC Bounty Board 101-150#pa (1): Done talking
NPC Bounty Board 81-120#gef (0) shown minimap indicator at location 194, 161 with the color [R:255, G:128, B:0, A:0]
NPC Bounty Board 101-150#pa (1) shown minimap indicator at location 192, 161 with the color [R:255, G:128, B:0, A:0]
NPC Bounty Board 121-175#pa (2) shown unknown effect 9999 at location 190, 161 with the color [R:255, G:255, B:0, A:0]
NPC Bounty Board 141#pay2 (3) shown unknown effect 9999 at location 188, 162 with the color [R:255, G:255, B:0, A:0]
Done talking with NPC Bounty Board 101-150#pa (1).
Talking to NPC at (192, 161) using sequence: c c r0 c r4 n
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: You've stumbled upon what appears to be a bulletin board with wanted ads.
Bounty Board 101-150#pa: Take a closer look?
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: There are many listings for monster hunting.
- Responses (Bounty Board 101-150#pa) --
# Response
0 Check bounty missions
1 Collect bounty rewards
2 Where do I go to hunt?
3 Search for other bounty hunters.
4 I want to QUIT hunting
5 Not interested.
6 Cancel Chat
----------------------------------------
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: There is a list of monsters on the board.
Bounty Board 101-150#pa: Looking through it you decide to take one hunting task.
- Responses (Bounty Board 101-150#pa) --
# Response
0 Axe Kobold
1 Hammer Kobold
2 Mace Kobold
3 Kobold Archer
4 Hunt All
5 Cancel
6 Cancel Chat
----------------------------------------
Bounty Board 101-150#pa: [Bounty Board]
Bounty Board 101-150#pa: There is a bounty to hunt 150 Axe Kobold, Hammer Kobold, Mace Kobold and Kobold Archer hunt them all.
Quest: Bounty Board Axe Kobold (62750) has been added.
Packet Parser: Unknown switch: 08FE
Quest: Bounty Board Hammer Kobold (62751) has been added.
Packet Parser: Unknown switch: 08FE
Quest: Bounty Board Mace Kobold (62752) has been added.
Packet Parser: Unknown switch: 08FE
Quest: Bounty Board Kobold Archer (62753) has been added.
Packet Parser: Unknown switch: 08FE
NPC Bounty Board 101-150#pa (1): Done talking
Unknown #57345 shown unknown effect 9999 at location 167, 102 with the color [R:255, G:255, B:0, A:0]
NPC Bounty Board 81-120#gef (0) shown minimap indicator at location 194, 161 with the color [R:255, G:128, B:0, A:0]
NPC Bounty Board 101-150#pa (1) shown unknown effect 9999 at location 192, 161 with the color [R:255, G:255, B:0, A:0]
NPC Bounty Board 121-175#pa (2) shown unknown effect 9999 at location 190, 161 with the color [R:255, G:255, B:0, A:0]
NPC Bounty Board 141#pay2 (3) shown unknown effect 9999 at location 188, 162 with the color [R:255, G:255, B:0, A:0]
Done talking with NPC Bounty Board 101-150#pa (1).
AI set to auto mode
[macro] automacro boardQuest triggered.
Calculating lockMap route to: Portus Luna(ra_fild06)

ScriptKiddy
Noob
Noob
Posts: 16
Joined: 12 Aug 2017, 06:07
Noob?: No

Re: Auto marco not triggering macro?

#4 Post by ScriptKiddy »

Mortimal wrote: Don't name macro and automacro the same, dont use call{ } construction it is buggy.

I will give that a try and report back. thank you for the reply tho!

ScriptKiddy
Noob
Noob
Posts: 16
Joined: 12 Aug 2017, 06:07
Noob?: No

Re: Auto marco not triggering macro?

#5 Post by ScriptKiddy »

Mortimal wrote:

Code: Select all

automacro boardQuest {
eval (($::questList->{62750}->{missions}->{1133}->{count} + $::questList->{62751}->{missions}->{1134}->{count} + $::questList->{62753}->{missions}->{1282}->{count} + $::questList->{62752}->{missions}->{1135}->{count}) >= 600)
exclusive 1
call boardQuestM
}

macro boardQuestM {
do ai manual
pause 2
do is Butterfly Wing
pause 5
do move lighthalzen 192 159
pause 15
do talknpc 192 161 c c r1 c r1 c c r0 n
pause 2
do talknpc 192 161 c c r0 c r4 n
do ai on
}
Unfortunately this code does not work either. I left it for a few hours, all quests are 100% complete which i can verify by the "quest list" command in the console. but it has not turned in the quests. I also noticed the lack of "auto macro triggered" message that the old code used to show. So i added a "timeout 60" line to your code but it still does not give any auto macro message and it still does not turn in the quests automatically.

However typing a manual command in the console "macro boardQuestM" still makes opencore run the macro correctly and turn in the quests. So not sure why it does not want to do it automatically :(

Mortimal
Developers
Developers
Posts: 389
Joined: 01 Nov 2008, 15:31
Noob?: No

Re: Auto marco not triggering macro?

#6 Post by Mortimal »

k than try this:

Code: Select all

automacro boardQuest {
eval (($::questList->{62750}->{missions}->{1133}->{count} >= $::questList->{62750}->{missions}->{1133}->{goal}) and  ($::questList->{62751}->{missions}->{1134}->{count} >=$::questList->{62751}->{missions}->{1134}->{goal}) and ($::questList->{62753}->{missions}->{1282}->{count} >= $::questList->{62753}->{missions}->{1282}->{goal}) and ($::questList->{62752}->{missions}->{1135}->{count} >= $::questList->{62752}->{missions}->{1135}->{goal}))
exclusive 1
call boardQuestM
}

macro boardQuestM {
do ai manual
pause 2
do is Butterfly Wing
pause 5
do move lighthalzen 192 159
pause 15
do talknpc 192 161 c c r1 c r1 c c r0 n
pause 2
do talknpc 192 161 c c r0 c r4 n
do ai on
}
Please use pin function for uploading your file contents!

ScriptKiddy
Noob
Noob
Posts: 16
Joined: 12 Aug 2017, 06:07
Noob?: No

Re: Auto marco not triggering macro?

#7 Post by ScriptKiddy »

Mortimal wrote:k than try this:
First of all, i really appreciate you taking the time to post these replys with new code. It's helping me understand how adding syntax or changing logic can really give a drastic change in the way a macro works!

Unfortunately this does not work. It automatically calls the macro, but it does so constantly, as if the quests are always completed, when they are not.

I've been searching deeper and deeper and i've found that open kore has a github page with a issue log. I've noticed there is a few issues about quests since December 2016 and specifically there seems to have been some changes with iRO and its new chapter, which has caused quest counts to be inaccurate when trying to return the values. As far as i can see the standard eval automacros do not work.

the closest thing to a post with actual coding published that seems to work now is the thread here: https://github.com/OpenKore/openkore/pull/914

I'm going to keep reading the issues on the github and experiment with new code and syntax.

Post Reply