Openkore.com

OpenKore Forums
It is currently 15 Dec 2018, 04:44

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: Can someone help me to fix macro please.
PostPosted: 16 Nov 2018, 14:03 
Offline
Noob
Noob

Joined: 16 Nov 2018, 13:12
Posts: 2
Hello. I am making macro for training ground completion. For now it looks like this and i have got some problem already.

Code:
automacro Novice1a {
   exclusive 1
   run-once 1
   base == 1
   class Novice
   eval $::config{BeginNovice} eq ""
   call NoviceBegin1
}
macro NoviceBegin1 {
[
   do conf skillsAddAuto_list Basic skills 9
   do conf attackAuto 0
   do conf autoTalkCont 0
   do conf lockMap none
   do conf saveMap none
   do conf route_randomWalk 0
   pause 15
   do move 53 113
   pause 5
   do talknpc 53 114 c c c c c c c n
   pause 6
   do move 146 112
   pause 5
   do conf QuestPart Novice1
]
}
automacro Novice1b {
   exclusive 1
   eval $::config{QuestPart} eq "Novice1"
   run-once 1
   call NoviceBegin2
}
macro NoviceBegin2 {
[
   do move 99 29
   pause 5
   do talknpc 100 29 c c c c r0 c n
   pause 7
   do conf QuestPart Novice2
]
}
automacro Novice1c {
   exclusive 1
   eval $::config{QuestPart} eq "Novice2"
   run-once 1
   call NoviceBegin3
}
macro NoviceBegin3 {
[
   do move 100 104
   do talknpc 100 105 c c c c c c c c c c c c n
   pause 15
   do eq Tattered Novice Ninja Suit
   pause 5
   do eq Novice Slippers
   pause 5
   do eq Novice Main-Gauche
   pause 5
   do eq Novice False Eggshell
   pause 5
   do talknpc 100 105 c c c c c c c c c c c n
   pause 15
   do conf QuestPart Novice3
]
}


So the problem is he is trying to complete all commands at once. For example he doesn't talk to first npc at 53 114, move to the next location straight away while trying to equip novice items.


Top
 Profile  
 
 Post subject: Re: Can someone help me to fix macro please.
PostPosted: 16 Nov 2018, 14:29 
Offline
OpenKore Monk
OpenKore Monk
User avatar

Joined: 17 Nov 2017, 23:32
Posts: 488
Location: Genting Highland, Malaysia
Just remove those brackets [ ].

Tips for writing macros:
-Start with basics
-Improvise
-Revert changes if new edit won't work.

Follow the SOP ;)

_________________

I'll not give answer. I'll just showing you the way to find it
Wiki & Google are your best allies. If you're lazy to read I won't bother answering
Image


Top
 Profile  
 
 Post subject: Re: Can someone help me to fix macro please.
PostPosted: 18 Nov 2018, 03:10 
Offline
Noob
Noob

Joined: 16 Nov 2018, 13:12
Posts: 2
Thank you for help. Almost got macro from novice to thief except the one problem with training ground quest.

Code:
automacro PoringQuest {
    eval $::config{QuestPart} eq "Poring"
    timeout 30
    macro_delay 3
    call {
    if (&questCompleteCount(7122) == 1) call StartNext
    }
}
macro StartNext {
    do mconf 1002 0
    do mconf 1014 2
    do conf QuestPart Novice7
}


So he is not starting next part of macro(StartNext) when one poring dies and keep killing them till the end.


Top
 Profile  
 
 Post subject: Re: Can someone help me to fix macro please.
PostPosted: 18 Nov 2018, 04:13 
Offline
OpenKore Monk
OpenKore Monk
User avatar

Joined: 17 Nov 2017, 23:32
Posts: 488
Location: Genting Highland, Malaysia
gutiman wrote:
Code:
    if (&questCompleteCount(7122) == 1) call StartNext



This is for eventMacro, not old macro.
They aren't the same yet very similar.
You just missed a few stuff, not that much.
Read again at the wiki.
Hope this give you some insight where you are going wrong & how to fix it.

http://openkore.com/index.php/EventMacro
http://wiki.openkore.com/index.php/Macro_plugin

_________________

I'll not give answer. I'll just showing you the way to find it
Wiki & Google are your best allies. If you're lazy to read I won't bother answering
Image


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group