koreSnarl - Snarl notification support (Win32) (8/26/08)

[sli]

Bump for bug fix.

[Engydoggy]

Sli, when you have a chance, take a look at the item notification section. Would be nifty.

[sli]

Sli, when you have a chance, take a look at the item notification section. Would be nifty.

Why? Is it not working?

[Engydoggy]

Hmm, it doesn't work for me, doesn't notify on item, but all other notifications do work. It should be properly installed I think, if all other types of notifications work

Is there a specific servertype for this to work? I already tried running kore from source, just in case, and it didn't work either :O

[sli]

Nope. Nothing special required. In fact, it's completely independent of server types as the hook is called when the message is printed. Here's the hook code from Receive.pm (just Receive.pm, not a ServerType module):

Code: Select all

		my $disp = TF("Item added to inventory: %s (%d) x %d - %s",
			$item->{name}, $item->{invIndex}, $amount, $itemTypes_lut{$item->{type}});
		message "$disp\n", "drop";
		$disp .= " ($field{name})\n";
		itemLog($disp);

		Plugins::callHook('item_gathered',{item => $item->{name}});

		$args->{item} = $item;

You sure you're using THE ABSOLUTE most current version? It changes a lot.

[sli]

Whoops, death bug was even more broken. Fixed it for real this time.

[sli]

Bump for awesome new feature!

[kong]

UPDATE: One bug to fix: if another player near you gains a level or job level, a notification is displayed for your character.

One question: Are the hook calls in Network/Receive.pm intended to be used with koreSnarl only?

Code: Select all

if ($type == 0) {
	message TF("%s gained a level!\n", $name);
	Plugins::callHook('base_level', {name => $name});
} elsif ($type == 1) {
	message TF("%s gained a job level!\n", $name);
	Plugins::callHook('job_level', {name => $name});
} elsif ...

If so, it's quite simple to only call the hooks when they belong to our character -- something like this:

Code: Select all

if ($type == 0) {
	message TF("%s gained a level!\n", $name);
	if ($ID eq $accountID) {
		Plugins::callHook('base_level', {name => $name});
	}
} elsif ($type == 1) {
	message TF("%s gained a job level!\n", $name);
	if ($ID eq $accountID) {
		Plugins::callHook('job_level', {name => $name});
	}
} elsif ...

Or we could just pass an additional parameter to the hook call (e.g. $ID) and do the filter in the plugin.

Just another idea for this great plugin

[sli]

No, they're intended for any character. It already already checks character names (or is supposed to) but it's using the wrong variable at the moment. I've fixed it, but haven't been able to test because Kore-RO is down. I'd just run a server here locally, but there's a whole big runaround for that (ie, hacking the Kore-RO client to use sclientinfo since all other clients inexplicably crash after service selection).

Then again, if I remember correctly, there's a way to enable service selection in the sclientinfo. It's just been a really long time since I was THE clientinfo guru, so yeah.

[Technology]

koreSnarl in now in SVN:
https://openkore.svn.sourceforge.net/sv ... koreSnarl/