r8243 sendGetCharacterName changes

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

Message
Author
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

r8243 sendGetCharacterName changes

#1 Post by EternalHarvest »

http://openkore.svn.sourceforge.net/vie ... threv=8243

Overrided in ServerType0 by old function, looks like it's totally unused everywhere except kRO.

http://openkore.svn.sourceforge.net/vie ... threv=8243

Just remove instead of commenting, and propagate changes to other 20 files with sendGetCharacterName in kRO, where it's overrided.

Do you use grep when doing such changes, ever?

The r8243 commit by itself contains too much unrelated feature changes together. It's preferable to limit one commit to one feature change, if possible.