skill_post_delay differences

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

Message
Author
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

skill_post_delay differences

#1 Post by EternalHarvest »

Introducing alternate packet name with alternate argument names for already existing packet, and implementing corresponding handler only in half of openkore isn't a good idea. Such issues are prevented entirely with by grep or similar tools to search for names, packet IDs and other things you're working on.

I've changed all names to more recent ones only due to absence of handler for old one (so it's probably not used at all). Usually the oldest naming should be used in such cases, unless stuff is being massively renamed.