Openkore.com

OpenKore Forums
It is currently 19 Apr 2018, 13:48

All times are UTC - 5 hours [ DST ]





Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 31 posts ]  Go to page Previous  1, 2, 3, 4  Next
Author Message
 Post subject: Re: RO Structs
PostPosted: 04 Jul 2010, 16:05 
Offline
Administrator
Administrator
User avatar

Joined: 24 Apr 2008, 12:02
Posts: 1299
Double Posting....

Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.

_________________
Join our Team. Click here.
Image


Image


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 04 Jul 2010, 16:15 
Offline
Super Moderators
Super Moderators
User avatar

Joined: 06 May 2008, 12:47
Posts: 801
kLabMouse wrote:
Double Posting....

Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.

Could you post an example of this in the structs please?

_________________
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 04 Jul 2010, 16:18 
Offline
Developers
Developers

Joined: 05 Dec 2008, 05:42
Posts: 1811
Can it be fixed with inserting unused fields of necessary lengths?


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 04 Jul 2010, 16:20 
Offline
Super Moderators
Super Moderators
User avatar

Joined: 06 May 2008, 12:47
Posts: 801
EternalHarvest wrote:
Can it be fixed with inserting unused fields of necessary lengths?

yea, i was thinking we could do this as last resort solution too.
But lets first confirm there is a problem before we even begin to think of solving it.

Btw, take a look at some pack strings in these files:
Code:
src/Network/Send/kRO$ grep -r --include="*.pm" " x" *

Is this struct alignment, bit-fields, some sort of padding or just missing packstring info?

_________________
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 04 Jul 2010, 16:43 
Offline
Administrator
Administrator
User avatar

Joined: 24 Apr 2008, 12:02
Posts: 1299
Technology wrote:
Could you post an example of this in the structs please?

I've forgot where it was, but I know, there was some discussion on IRC in about 6~9mo ago about some packet, that had no good struct because of "char" type used in it.

_________________
Join our Team. Click here.
Image


Image


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 05 Jul 2010, 18:58 
Offline
Super Moderators
Super Moderators
User avatar

Joined: 06 May 2008, 12:47
Posts: 801
Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.

_________________
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 05 Jul 2010, 20:19 
Offline
Administrator
Administrator
User avatar

Joined: 24 Apr 2008, 12:02
Posts: 1299
Technology wrote:
Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.

So what are additional 2 bytes?

_________________
Join our Team. Click here.
Image


Image


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 20 Jul 2010, 19:03 
Offline
Administrator
Administrator
User avatar

Joined: 24 Apr 2008, 12:02
Posts: 1299
kLabMouse wrote:
Technology wrote:
Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.

So what are additional 2 bytes?

Checked. No info on additional 2 bytes.

But.. they added COSTUME item type.
So may-be it's related to it.

_________________
Join our Team. Click here.
Image


Image


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 20 Jul 2010, 21:05 
Offline
Developers
Developers

Joined: 05 Dec 2008, 05:42
Posts: 1811
kLabMouse wrote:
But.. they added COSTUME item type.

Image


Top
 Profile  
 
 Post subject: Re: RO Structs
PostPosted: 20 Jul 2010, 21:47 
Offline
Administrator
Administrator
User avatar

Joined: 24 Apr 2008, 12:02
Posts: 1299
Uploading latest Works.
Packets up to 0x824 + HEADER's up to 0x83f
+ ENUM's


Attachments:
File comment: Packet Struct and ENUMS Up to May 2010
packet_structs_and_enums.zip [105.58 KiB]
Downloaded 39 times

_________________
Join our Team. Click here.
Image


Image
Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 31 posts ]  Go to page Previous  1, 2, 3, 4  Next

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group