Page 2 of 4
Re: RO Structs
Posted: 04 Jul 2010, 16:05
by kLabMouse
Double Posting....
Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.
Re: RO Structs
Posted: 04 Jul 2010, 16:15
by Technology
kLabMouse wrote:Double Posting....
Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.
Could you post an example of this in the structs please?
Re: RO Structs
Posted: 04 Jul 2010, 16:18
by EternalHarvest
Can it be fixed with inserting unused fields of necessary lengths?
Re: RO Structs
Posted: 04 Jul 2010, 16:20
by Technology
EternalHarvest wrote:Can it be fixed with inserting unused fields of necessary lengths?
yea, i was thinking we could do this as last resort solution too.
But lets first confirm there is a problem before we even begin to think of solving it.
Btw, take a look at some pack strings in these files:
Code: Select all
src/Network/Send/kRO$ grep -r --include="*.pm" " x" *
Is this struct alignment, bit-fields, some sort of padding or just missing packstring info?
Re: RO Structs
Posted: 04 Jul 2010, 16:43
by kLabMouse
Technology wrote:Could you post an example of this in the structs please?
I've forgot where it was, but I know, there was some discussion on IRC in about 6~9mo ago about some packet, that had no good struct because of "char" type used in it.
Re: RO Structs
Posted: 05 Jul 2010, 18:58
by Technology
Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.
Re: RO Structs
Posted: 05 Jul 2010, 20:19
by kLabMouse
Technology wrote:Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.
So what are additional 2 bytes?
Re: RO Structs
Posted: 20 Jul 2010, 19:03
by kLabMouse
kLabMouse wrote:Technology wrote:Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.
So what are additional 2 bytes?
Checked. No info on additional 2 bytes.
But.. they added COSTUME item type.
So may-be it's related to it.
Re: RO Structs
Posted: 20 Jul 2010, 21:05
by EternalHarvest
kLabMouse wrote:But.. they added COSTUME item type.
Re: RO Structs
Posted: 20 Jul 2010, 21:47
by kLabMouse
Uploading latest Works.
Packets up to 0x824 + HEADER's up to 0x83f
+ ENUM's