Openkore.com

OpenKore Forums
It is currently 18 Jun 2018, 17:17

All times are UTC - 5 hours [ DST ]





Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 2 posts ] 
Author Message
 Post subject: r7640
PostPosted: 29 Jun 2011, 22:14 
Offline
Developers
Developers

Joined: 05 Dec 2008, 05:42
Posts: 1811
At first I was like, why there is a BOM? But then...

http://openkore.svn.sourceforge.net/vie ... 38&r2=7640

- introduced BOM for no reason (already fixed)
- 'c24 c24 c24 c24 c24 c24 c24 c24 c24 c24', [qw(name1 name2 name3 name4 name5 name6 name7 name8 name9 name10)] - 'c24'? Like, 24 separate values of 'c'?
- handler names (like GANSI_RANK) inconsistent with other handler names in kore, in capitalization at least
- whole bunch of commented (!) identical packets, probably either wrong or unused (already fixed)
- unicode text (in comments) turned into garbage
- actor_quest_effect empty (only debug) handler which could have been just merged into misc_effect

Looks like I need to go back and review all the revisions I skipped somehow.

It isn't that bad, but some of that stuff needs fixing.


Top
 Profile  
 
 Post subject: Re: r7640
PostPosted: 07 Jul 2011, 18:12 
Offline
Administrator
Administrator
User avatar

Joined: 24 Apr 2008, 12:02
Posts: 1299
It was one of the first commits from DrKN.
So don't be that hard, everybody can make mistakes.

_________________
Join our Team. Click here.
Image


Image


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 2 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group