r7640

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderator: Moderators

Message
Author
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

r7640

#1 Post by EternalHarvest »

At first I was like, why there is a BOM? But then...

http://openkore.svn.sourceforge.net/vie ... 38&r2=7640

- introduced BOM for no reason (already fixed)
- 'c24 c24 c24 c24 c24 c24 c24 c24 c24 c24', [qw(name1 name2 name3 name4 name5 name6 name7 name8 name9 name10)] - 'c24'? Like, 24 separate values of 'c'?
- handler names (like GANSI_RANK) inconsistent with other handler names in kore, in capitalization at least
- whole bunch of commented (!) identical packets, probably either wrong or unused (already fixed)
- unicode text (in comments) turned into garbage
- actor_quest_effect empty (only debug) handler which could have been just merged into misc_effect

Looks like I need to go back and review all the revisions I skipped somehow.

It isn't that bad, but some of that stuff needs fixing.

User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: r7640

#2 Post by kLabMouse »

It was one of the first commits from DrKN.
So don't be that hard, everybody can make mistakes.

Locked