Page 1 of 1

r7640

Posted: 29 Jun 2011, 22:14
by EternalHarvest
At first I was like, why there is a BOM? But then...

http://openkore.svn.sourceforge.net/vie ... 38&r2=7640

- introduced BOM for no reason (already fixed)
- 'c24 c24 c24 c24 c24 c24 c24 c24 c24 c24', [qw(name1 name2 name3 name4 name5 name6 name7 name8 name9 name10)] - 'c24'? Like, 24 separate values of 'c'?
- handler names (like GANSI_RANK) inconsistent with other handler names in kore, in capitalization at least
- whole bunch of commented (!) identical packets, probably either wrong or unused (already fixed)
- unicode text (in comments) turned into garbage
- actor_quest_effect empty (only debug) handler which could have been just merged into misc_effect

Looks like I need to go back and review all the revisions I skipped somehow.

It isn't that bad, but some of that stuff needs fixing.

Re: r7640

Posted: 07 Jul 2011, 18:12
by kLabMouse
It was one of the first commits from DrKN.
So don't be that hard, everybody can make mistakes.