Preparations for 2.1 release discussion

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderator: Moderators

Message
Author
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Preparations for 2.1 release discussion

#1 Post by EternalHarvest »

It looks like the most of important stuff is done (except xKore 1, random bugs in AI and maybe bugs in the most recent features).

Is there something else we're missing?

And about recently added stuff: maybe instead of locale_compat boolean option add more useful one, which will specify which tablepack to use? Just like --tables. And 'locale_compat 1' will become something like 'tables tables/Old', not so hard.

User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: Preparations for 2.1 release discussion

#2 Post by kLabMouse »

EternalHarvest wrote:It looks like the most of important stuff is done (except xKore 1, random bugs in AI and maybe bugs in the most recent features).

Is there something else we're missing?
Nothing more. Just "Status Handle" and "xKore 1".
All this is not hard at all.
EternalHarvest wrote: And about recently added stuff: maybe instead of locale_compat boolean option add more useful one, which will specify which tablepack to use? Just like --tables. And 'locale_compat 1' will become something like 'tables tables/Old', not so hard.
Could be. but "locale_compat" was made to make Kore compatible with old configs, because Statuses/Skills where updated and localized.


Still 2.1 will be the last release that supports numbered ST's.
Also, in future versions, we better concentrate on xKore rewrite and Actor system Rewrite.
So we loose thus things that take OpenKore down, and makes too much bug's.

My suggestion, is now fix/make thus two changes to Kore. So we could Release and branch out "stable" Release.
"stable" branch will be bug fix only, while we implement new features and some code Rewrite in "trunk".

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Preparations for 2.1 release discussion

#3 Post by EternalHarvest »

kLabMouse wrote:Nothing more. Just "Status Handle" and "xKore 1".
Status handles are implemented.
kLabMouse wrote:"locale_compat" was made to make Kore compatible with old configs, because Statuses/Skills where updated and localized.

Still 2.1 will be the last release that supports numbered ST's.
Is there anything beside tables switch that's done for that type of compatibility, or will be? Presence of numbered STs irrelevant.

User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: Preparations for 2.1 release discussion

#4 Post by kLabMouse »

EternalHarvest wrote: Is there anything beside tables switch that's done for that type of compatibility, or will be? Presence of numbered STs irrelevant.
Nothing More. The table switch must change the loading files, just like "--tables" switch.
It was made simple to use, and all Old/Changed files located, and must be loaded from "tables\Old", that are made for compatibility reasons.

Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: Preparations for 2.1 release discussion

#5 Post by Technology »

xkore1 works on all servers, there are just a few minor quirks:
- You can't use the public chat ;command. (But you can use party/guild/private chat ;command.)
- On some places ai_clientSuspend isn't called.
- $char->{look}{head} and $char->{look}{body} aren't updated in kore

Lets take a look at the parseOutgoingClientMessage sub in functions.pl
To fix the quirks, you could hook RO_sendMsg_pre in the designated serverTypes.
This would move all server specific stuff to the serverTypes and remove the need for checks like:
$switch eq "0072" && $masterServer->{serverType} == 13
There is one more thing that bothers me, the substr unpacking.
It would be awesome if we could just use the pack strings of our sent packets to unpack these packets.
We could do so if we implemented this.


Now, for something completely different.
May i suggest we rename the .grf extracted tables back to their original name?

Code: Select all

[grf files]
itemslots.txt         itemslottable.txt
maps.txt            mapnametable.txt
itemslotcounttable.txt   itemslotcounttable.txt
itemsdescriptions.txt   idnum2itemdesctable.txt
items.txt            idnum2itemdisplaynametable.txt
quests.txt            questid2display.txt
resnametable.txt      resnametable.txt
skilldescriptions.txt   skilldesctable2.txt
skillsp.txt            leveluseskillspamount.txt
This is only a minor effort, but will help those that extract the table files.
this was suggested here
also, maybe we can we make %skillSP_lut obsolete?
done
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Preparations for 2.1 release discussion

#6 Post by EternalHarvest »

skillsailments.txt needs status handles.

Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: Preparations for 2.1 release discussion

#7 Post by Technology »

wxstart.exe doesn't display colored text
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Preparations for 2.1 release discussion

#8 Post by EternalHarvest »

Btw Mailed items are not removed from inventory. More mislogic behind this in comments in Receive::ST0.

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Preparations for 2.1 release discussion

#9 Post by EternalHarvest »

(Tried to configure all chat messages to be on different background for better separation)

consolecolors.txt background color doesn't mix well in terminal, maybe problems with other interfaces, too (seems like Wx ignores settings which include background color).

Image

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Preparations for 2.1 release discussion

#10 Post by EternalHarvest »

EternalHarvest wrote:consolecolors.txt background color doesn't mix well in terminal
Fixed for Console::Simple.

Locked