Openkore.com

OpenKore Forums
It is currently 21 Oct 2018, 00:42

All times are UTC - 5 hours [ DST ]





Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 3 posts ] 
Author Message
 Post subject: Macro plugins bug
PostPosted: 21 Aug 2013, 05:51 
Offline
Noob
Noob

Joined: 19 May 2010, 09:17
Posts: 9
After few months to make sure,
Some features in Macro plugin doesn't work as its supposed to be...
( I already trying to use direcly copy from http://sourceforge.net/p/openkore/code/ ... gins/macro in hope to get fresh macro, but still doesn't work )

for now I only found 2 problesm, (could be more, but I still learning how the macro work despite I am using it for months)
  • class is bugged, so if I put 2 classes condition, like this example
    Code:
    automacro BuffRequest {
    #class Stalker
    #class Ranger
    player /(Random|Support|Name)/i , 15
    status not EFST_GLORIA
    hp > 85%
       timeout 1
       call {
          do e mp
       }
    }


    It won't trigger, unless I eliminate the classes until it only specify one classes (according to manuals, its supposed treated as OR condition)
  • [second one are elsif { } and else { }
    They won't work, so instead using elsif or else, I still using
    Code:
    if ( ) goto label
    :label
    do blah

    Edit: After numeour copy paste ( I cann't tell which one is which, because they're all written as macro plugin version 2.0.3-svn macro.pl 6744) but seem its no longer a problem, its working not.

    Previously, if my macro status still written as EFST_(*.) it still error, now unknownly my macro status now show proper status like Magnificat, Gloria, etc... instead EFST, that else { is work, although still need a test..

    Last time I check it, I suspect because I write
    Code:
    }
    else {
    instead
    Code:
    } else {
    (different lines)


I also suspecting targetGround doesn't work, but I dont have any character yet that require that conditon (or haven't encountered yet), I still exploring the macro so, I might wrong but I can make sure that I am using
Code:
macro plugin version 2.0.3-svn
macro.pl 6744
macro::Automacro 6760
macro::Script 6782
macro::Parser 6759
macro::Utilities 6812
macro::Data 6753


Thx in advance


Last edited by kangtuji on 21 Aug 2013, 19:27, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: Macro plugins bug
PostPosted: 21 Aug 2013, 06:55 
Offline
Developers
Developers

Joined: 05 Dec 2008, 05:42
Posts: 1811
kangtuji wrote:
class is bugged, so if I put 2 classes condition, like this example ...It won't trigger, unless I eliminate the classes until it only specify one classes (according to manuals, its supposed treated as OR condition)

Manual was totally wrong there. Multiple conditions are generally treated as "and", and it's meaningless for "class". Also, it seems "class" lacks the usual way to specify "or". That needs to be implemented.


Top
 Profile  
 
 Post subject: Re: Macro plugins bug
PostPosted: 31 Aug 2013, 16:08 
Offline
OpenKore Monk
OpenKore Monk

Joined: 08 Jun 2012, 15:42
Posts: 401
Location: Brazil
I finished implementing the commands if (condition) {, else { and elsif (condition) { in the 8584 revision of the Macro Plugin. You are using this review? Check using TortoiseSVN.

The parser Macro Plugin is very simple, it really will inform error when write the command like this:
Code:
if (condition)
{

Works just as well:
Code:
if (codition) {

I purposely kept so for the macros have a pattern and be easy to read




If you are using the version and still not working properly the macro, it could report on this topic?

_________________
Image


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 3 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group