r7295 - Looting Behaviour

[Thrice]

At present, looting will get interrupted by Auto-Buy and Auto-Sit, which will look like this:

[Date 13:37:13] Item Appeared: Super Rare Item (0) x 1 (226, 196)
[Date 13:37:14] You are sitting.

or

[Date 13:37:39] Item Appeared: Super Rare Item (0) x 1 (226, 196)
[Date 13:37:40] Auto-buy: Red Potion
Teleporting to auto-buy
[Date 13:37:40] Permitted to use Teleportation (26), level 2

Seriously, why would you use a butterfly wing or just sit there, when a super rare item just dropped in front of you?

In my config I have:

Code: Select all

itemsTakeAuto 1
itemsGatherAuto 1

But regardless of these settings, this shouldn't happen, should it?


To prevent kore doing so I've modified CoreLogic.pm:

Add: && !AI::inQueue("take")

Code: Select all

 line 1497+
#####AUTO BUY#####
sub processAutoBuy {
		my $needitem;
	if ((AI::action eq "" || AI::action eq "route" || AI::action eq "follow") && timeOut($timeout{'ai_buyAuto'}) && time > $ai_v{'inventory_time'} && !AI::inQueue("take")) {

Code: Select all

 line 2183+
	# Sit if we're not already sitting
	if ($action eq "sitAuto" && !$char->{sitting} && $char->{skills}{NV_BASIC}{lv} >= 3 &&
	    !ai_getAggressives() && ($weight < 50 || $config{'sitAuto_over_50'}) 
		&& !AI::inQueue("take")) { ### Don't sit before taking items first!
		debug "sitAuto - sit\n", "sitAuto";
		sit();

The Auto-Buy modification does seem to work like a charm.
I am not quite sure bout the sitting modification, but so far it does seem ok.


Another thing I've noticed, but haven't looked into yet:

Sometimes kore will ignore dropped items, especially when using ranged chars.
E.g: My Archer uses Double Strafe to one shot a mob, a card drops and the bot will just walk away.

[kLabMouse]

Moved to Bug Reports.
Patch should be checked and probably commited.