r8883 - Inventory output reversed/altered

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderators: Moderators, Developers

Message
Author
User avatar
4epT
Developers
Developers
Posts: 617
Joined: 30 Apr 2008, 14:17
Noob?: No
Location: Moskow (Russia)
Contact:

Re: r8883 - Inventory output reversed/altered

#11 Post by 4epT »

- Removed one-liner comment for cmdInventory description
Lead by example, that you deleted?
- And added POD style comment block describing the behaviour of the routine instead
why is it necessary? I think this superfluous.
All my posts are made by machine translator!
¤ Manual ¤ Anti BotKiller ¤ Packet Extractor v3 ¤
Image
Image

User avatar
ChrstphrR
Testers Team
Testers Team
Posts: 42
Joined: 09 May 2010, 17:30
Noob?: No
Location: Northern Alberta, Canada

Re: r8883 - Inventory output reversed/altered

#12 Post by ChrstphrR »

You might think having a comment block that described how the routine works is superfluous, but you have no compunction to alter how routines work without even a mention; not in source, not in commit logs.

People changing how the program works, without documenting it along the way, will only serve to annoy the userbase.

The original group of coders did put more than terse explanations in front of their routines to explain what they did; take a look at
http://sourceforge.net/p/openkore/code/ ... sNotes.txt

rocknroll
Been there done that!
Been there done that!
Posts: 118
Joined: 19 Sep 2011, 07:30
Noob?: Yes

Re: r8883 - Inventory output reversed/altered

#13 Post by rocknroll »

well done ChrstphrR, i agree with u.
Sorry, my english is very bad !

Locked