Page 1 of 1

bRO --- r7915 Patch for bug infos de quests

Posted: 03 Jan 2012, 10:18
by KoreGhost

Code: Select all

Index: Network/Receive/bRO.pm
===================================================================
--- Network/Receive/bRO.pm    (revision 7915)
+++ Network/Receive/bRO.pm    (working copy)
@@ -46,4 +46,7 @@
     }
 }
 
+*parse_quest_update_mission_hunt = *Network::Receive::ServerType0::parse_quest_update_mission_hunt_v2;
+*reconstruct_quest_update_mission_hunt = *Network::Receive::ServerType0::reconstruct_quest_update_mission_hunt_v2;
+
 1;
\ No newline at end of file
Credits: http://openkore.com.br/index.php?/user/77-imikelance/

Code: Select all

Index: Misc.pm
===================================================================
--- Misc.pm    (revision 7921)
+++ Misc.pm    (working copy)
@@ -3876,6 +3876,11 @@
     if (defined $config{$prefix.'_devotees'}) {
         return 0 unless inRange(scalar keys %{$devotionList->{$accountID}{targetIDs}}, $config{$prefix.'_devotees'});
     }
+        
+    if ($config{$prefix."_avoidGutterLines"}) {
+        my $pos = calcPosition($char);
+        return 0 if ($pos->{x}%40 <= 4 || $pos->{y}%40 <= 4);
+    }
 
     my %hookArgs;
     $hookArgs{prefix} = $prefix;
Usage:

Utilizando:

Code: Select all

# bRO: Impacto de Tyr
attackSkillSlot Bowling Bash {
avoidGutterLines 1
}

Re: bRO --- r7915 Patch for bug infos de quests

Posted: 03 Jan 2012, 11:08
by iMikeLance
The first one addresses a bug already fixed in iRO where kore would report the number of monsters killed during a quest incorrectly. So it's just copy/paste from Network/Receive/iRO.pm.

The second one adds the Self Condition avoidGutterLines, where kore checks if the character is inside any gutter line before casting the skill. It's only useful for Bowling Bash in official servers.

Re: bRO --- r7915 Patch for bug infos de quests

Posted: 03 Jan 2012, 13:57
by EternalHarvest
bRO update: in r7924.

avoidGutterLines: it's fine, but maybe more suited as a plugin, as "it's only useful for Bowling Bash in official servers"?
Example of how to implement a self condition in a plugin: http://openkore.svn.sourceforge.net/vie ... iew=markup

Re: bRO --- r7915 Patch for bug infos de quests

Posted: 04 Jan 2012, 10:55
by iMikeLance
Commit by farrainbow :: r7924 /openkore/trunk/src/Network/Send/bRO.pm:
bRO quest_update_mission_hunt update (by iMikeLance)
Updated to last rev today and found out that the patch has been added to Send/bRO.pm, and it should've been applied to Receive/bRO.pm.
EternalHarvest wrote:bRO update: in r7924.

avoidGutterLines: it's fine, but maybe more suited as a plugin, as "it's only useful for Bowling Bash in official servers"?
Example of how to implement a self condition in a plugin: http://openkore.svn.sourceforge.net/vie ... iew=markup
Thanks for the suggestion about the plugin, gonna start it just after bRO's maintenance :D