Openkore.com

OpenKore Forums
It is currently 22 May 2018, 05:53

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: r8845 bus-server.pl spawned THOUSANDS of times.
PostPosted: 16 Mar 2014, 21:37 
Offline
Testers Team
Testers Team

Joined: 09 May 2010, 17:30
Posts: 42
Location: Northern Alberta, Canada
There is something in the change to either the bus-server.pl in revision 8845, or the code that calls it that is clearly broken for me:

Backgrounder:
  • Running openkore, revision 8848, updated via SVN
  • Running Ubuntu
  • Running 4 instances of openkore in separate screen windows, using the Console interface.
  • All 4 loading iMikeLance's busCommands plugin (but not really using it).

After a length of time, with me not monitoring the instance or four of openkore running on the Console interface, they lock up, and I can only seem to regain control via:

killall perl
Killing each window running openkore in screen, because it no longer displays anything shown on screen by kore, nor in the shell, after running killall perl.

Normally, I'm able to run these instances for 6 or 7 days up.

After the 3rd time noting this issue, I paused and checked the process list, using "ps -A".
This is a SMALL exerpt of a "ps -A" listing on the ubuntu machine in question.
Read this carefully: It is *5172 lines long*, of which < 100 other processes are NOT perl.
Code:
2492 ?        00:01:47 perl
2496 ?        00:00:00 perl <defunct>
2497 ?        00:00:00 perl
2510 ?        00:00:00 perl <defunct>
2511 ?        00:00:00 perl
2513 ?        00:01:32 perl
2517 ?        00:00:00 perl <defunct>
2518 ?        00:00:00 perl
2519 ?        00:00:00 perl <defunct>
2520 ?        00:00:00 perl
2522 ?        00:01:51 perl
2526 ?        00:00:00 perl <defunct>
2527 ?        00:00:00 perl
2528 ?        00:00:00 perl <defunct>
2529 ?        00:00:00 perl
2530 ?        00:00:00 perl <defunct>
2531 ?        00:00:00 perl
2532 ?        00:00:00 perl <defunct>
2533 ?        00:00:00 perl <defunct>
2534 ?        00:00:00 perl
2535 ?        00:00:00 perl
2536 ?        00:00:00 perl <defunct>
2537 ?        00:00:00 perl
2538 ?        00:00:00 perl <defunct>
2539 ?        00:00:00 perl
2540 ?        00:00:00 perl <defunct>
2541 ?        00:00:00 perl
2542 ?        00:00:00 perl <defunct>
2543 ?        00:00:00 perl
2544 ?        00:00:00 perl <defunct>
2545 ?        00:00:00 perl
2546 ?        00:00:00 perl <defunct>
2547 ?        00:00:00 perl
2548 ?        00:00:00 perl <defunct>
2549 ?        00:00:00 perl
2550 ?        00:00:00 perl <defunct>
2551 ?        00:00:00 perl
2552 ?        00:00:00 perl <defunct>
2553 ?        00:00:00 perl
2554 ?        00:00:00 perl <defunct>
2555 ?        00:00:00 perl
2556 ?        00:00:00 perl <defunct>
2557 ?        00:00:00 perl
2558 ?        00:00:00 perl <defunct>
2559 ?        00:00:00 perl
2560 ?        00:00:00 perl <defunct>
2561 ?        00:00:00 perl
2563 ?        00:05:24 perl
2566 ?        00:00:00 perl <defunct>
2567 ?        00:00:00 perl


Something about the ability to allow multiple Bus servers that revision 8845 enables is doing a tad more than that. It's spawning approximately 1,200 *extra* instances of perl running the bus-server.pl script per instance of openkore run.

I have reverted 8845 out of my local code base and will test further to see if the problem still occurs, or not. Can the coder responsible for this commit check over their contribution, and see if they can spot the change that causes a plethora of bus-servers to spawn?


Top
 Profile  
 
 Post subject: Re: r8845 bus-server.pl spawned THOUSANDS of times.
PostPosted: 17 Mar 2014, 08:52 
Offline
Moderators
Moderators
User avatar

Joined: 01 Feb 2010, 17:37
Posts: 211
Location: Brazil - MG
Revision: 8850
Author: marcelofoxes
Date: segunda-feira, 17 de março de 2014 09:45:44
Message:
viewtopic.php?f=56&t=182569 fix
----
Modified : /openkore/trunk/src/Bus/bus-server.pl

Sorry for that! Should work fine now.

_________________
Brazilian Community: http://openkore-brasil.com
BetaKore: https://code.google.com/p/betakore/


Top
 Profile  
 
 Post subject: Re: r8845 bus-server.pl spawned THOUSANDS of times.
PostPosted: 17 Mar 2014, 22:48 
Offline
Testers Team
Testers Team

Joined: 09 May 2010, 17:30
Posts: 42
Location: Northern Alberta, Canada
Seems to fix the issue, thank you.

Thank you for the prompt fix!

Obrigado pela correção rápida.


Top
 Profile  
 
 Post subject: Re: r8845 bus-server.pl spawned THOUSANDS of times.
PostPosted: 01 Apr 2014, 01:47 
Offline
Developers
Developers
User avatar

Joined: 30 Apr 2008, 14:17
Posts: 618
Location: Moskow (Russia)
show me how you use the bus-server

_________________
All my posts are made by machine translator!
¤ Manual ¤ Anti BotKiller ¤ Packet Extractor v3 ¤
Image
Image


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group