Openkore.com

OpenKore Forums
It is currently 18 Nov 2019, 21:16

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 6 posts ] 
Author Message
 Post subject: Something wrong in r8141 commit !!
PostPosted: 10 Sep 2012, 00:13 
Offline
Developers
Developers

Joined: 24 Nov 2010, 03:08
Posts: 214
The r8141 commited by marcellofoes seems something wrong !
The adding code is for checking the "leader-only party commands".
But these codes:
Code:
   } elsif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {
.......

Make the followings "elsif"'s never be excuted !!


Top
 Profile  
 
 Post subject: Re: Something wrong in r8141 commit !!
PostPosted: 10 Sep 2012, 06:03 
Offline
Moderators
Moderators
User avatar

Joined: 01 Feb 2010, 17:37
Posts: 211
Location: Brazil - MG
fixed: http://cia.vc/stats/project/openkore/.message/34bafe
thanks sofax222 :D

_________________
Brazilian Community: http://openkore-brasil.com
BetaKore: https://code.google.com/p/betakore/


Top
 Profile  
 
 Post subject: Re: Something wrong in r8141 commit !!
PostPosted: 10 Sep 2012, 06:15 
Offline
Developers
Developers

Joined: 05 Dec 2008, 05:42
Posts: 1811
"kick" and "leader" still seem to be broken.


Top
 Profile  
 
 Post subject: Re: Something wrong in r8141 commit !!
PostPosted: 10 Sep 2012, 06:44 
Offline
Moderators
Moderators
User avatar

Joined: 01 Feb 2010, 17:37
Posts: 211
Location: Brazil - MG
Working fine:

Code:
party request 1
You are the party leader.
TestPlayer1 entrou no seu grupo '"Test Party"'
TestPlayer1 aceitou seu pedido.
party
----------Grupo-----------
"Test Party"
#      Nome                  Mapa                   Online    HP
0  (A) TestKore          prontera      181, 100 Sim       540/540 (100%)
1      TestPlayer1                 prontera      182, 97  Sim       13480/13480
(100%)
--------------------------
party leader 1
You are the party leader.
New party leader: TestPlayer1
New party leader: TestKore
party kick 1
You are the party leader.
EXP do grupo Dividida Individualmente.
Party TestPlayer1 left the party (kicked)
EXP do grupo Dividida Individualmente.


Code:
party leader 1
You are the party leader.
New party leader: TestPlayer1
party kick 0
Error in function 'party kick'
You must be the party leader in order to use this !
party leader 0
Error in function 'party leader'
You must be the party leader in order to use this !
party share 0
Error in function 'party share'
You must be the party leader in order to use this !


But at least in bRO party request and friend request are broken. When you send party request kore actually sends a friend request and when sending friend request i got a DC. I can fix that but i'm downloading iRO to test it it's broken there too.

_________________
Brazilian Community: http://openkore-brasil.com
BetaKore: https://code.google.com/p/betakore/


Top
 Profile  
 
 Post subject: Re: Something wrong in r8141 commit !!
PostPosted: 10 Sep 2012, 12:14 
Offline
Plain Yogurt
Plain Yogurt

Joined: 02 Sep 2012, 11:09
Posts: 51
Location: Brazil - PR
sofax222 wrote:
The r8141 commited by marcellofoes seems something wrong !
The adding code is for checking the "leader-only party commands".
But these codes:
Code:
   } elsif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {
.......

Make the followings "elsif"'s never be excuted !!


} elseif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {


Top
 Profile  
 
 Post subject: Re: Something wrong in r8141 commit !!
PostPosted: 10 Sep 2012, 13:11 
Offline
Moderators
Moderators
User avatar

Joined: 01 Feb 2010, 17:37
Posts: 211
Location: Brazil - MG
5e13ct wrote:
sofax222 wrote:
The r8141 commited by marcellofoes seems something wrong !
The adding code is for checking the "leader-only party commands".
But these codes:
Code:
   } elsif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {
.......

Make the followings "elsif"'s never be excuted !!


} elseif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {



http://www.devdaily.com/blog/post/perl/perl-if-else-elsif-syntax-example wrote:
The Perl "else if" syntax (elsif)

In Perl the "else if" syntax actually uses the elsif keyword. Here's some example code showing this syntax:

Code:
if ($condition1)
{
  # do something
}
elsif ($condition2)
{
  # do something else
}
elsif ($condition3)
{
  # yada
}
else
{
  # do the 'else' thing
}


_________________
Brazilian Community: http://openkore-brasil.com
BetaKore: https://code.google.com/p/betakore/


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 6 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group