Page 1 of 2

Failed to take <Item> issue (RE:Start)

Posted: 18 Jul 2017, 23:27
by Macdoozy
Hi guys,

I've just finished setting up my bot and everything seems to be working except that my character always fails to pick up items.

I have tried changing itemsTakeAuto and itemsGatherAuto from 2 to 1 and it still does not work. I have also tried using the other algorithm for taking and gather by setting itemsTakeAuto_new to 1 and it doesn't work.

Any other suggestions that I can try to fix this issue?

Re: Failed to take <Item> issue (RE:Start)

Posted: 19 Jul 2017, 00:42
by Detritus
I wanted to bump this topic as I am having a very similar issue.

My bot will attack a monster, gain the exp, see an item on the ground, try to pick up the item, and then register the monster is dead.

I have tried what MacDoozy has tried in playing with the itemsTakeAuto set at 1 or 2, itemsTakeAuto_party set at 1 or 2, and the itemsTakeAuto_new set as 0, 1, or 2. Yes I have configured my pickupitems.txt - at first I tried all 1 and then all 2 and then all 0 and specifically listing the loot I wanted under all 0.

Is there a reason why my bot is registering the target dying so late? Is that an issue?

Re: Failed to take <Item> issue (RE:Start)

Posted: 19 Jul 2017, 23:38
by Aappoolloo
Macdoozy wrote:Hi guys,

I've just finished setting up my bot and everything seems to be working except that my character always fails to pick up items.

I have tried changing itemsTakeAuto and itemsGatherAuto from 2 to 1 and it still does not work. I have also tried using the other algorithm for taking and gather by setting itemsTakeAuto_new to 1 and it doesn't work.

Any other suggestions that I can try to fix this issue?
I believe the server has a feature that if you are not the one who killed the mob you cant get the items after 30 seconds.

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 00:17
by noobot
Aappoolloo wrote:
Macdoozy wrote:Hi guys,

I've just finished setting up my bot and everything seems to be working except that my character always fails to pick up items.

I have tried changing itemsTakeAuto and itemsGatherAuto from 2 to 1 and it still does not work. I have also tried using the other algorithm for taking and gather by setting itemsTakeAuto_new to 1 and it doesn't work.

Any other suggestions that I can try to fix this issue?
I believe the server has a feature that if you are not the one who killed the mob you cant get the items after 30 seconds.
I have this problem too and the server feature explanation is not the reason for this.
Even the items from bot's own targets cannot be gathered. Need to know the reason...

Any help is welcome, thanks!

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 00:36
by noobot
UPDATE:
I just fixed it from watching on GitHub.
https://github.com/OpenKore/openkore/co ... ad260c7952
This code update is the fix.

You can do one of the two things below: (Recommended option: 2)
1. Take whole GitHub update (and subsequently change/replace your config files for each bot).
2. Go to src/Network/Send/ServerType0.pm
- Go to Line 107
- You will see this line:

Code: Select all

'0362' => ['item_take', 'x4 a4', [qw(ID)]],
- Change it to:

Code: Select all

'0362' => ['item_take', 'a4', [qw(ID)]],
(Remove the 'x4 ' text from that line)

It will fix the problem.

You're welcome! :-)

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 00:54
by kali
noobot wrote:UPDATE:
I just fixed it from watching on GitHub.
https://github.com/OpenKore/openkore/co ... ad260c7952
This code update is the fix.

You can do one of the two things below: (Recommended option: 2)
1. Take whole GitHub update (and subsequently change/replace your config files for each bot).
2. Go to src/Network/Send/ServerType0.pm
- Go to Line 107
- You will see this line:

Code: Select all

'0362' => ['item_take', 'x4 a4', [qw(ID)]],
- Change it to:

Code: Select all

'0362' => ['item_take', 'a4', [qw(ID)]],
(Remove the 'x4 ' text from that line)

It will fix the problem.

You're welcome! :-)
The better option is 1. Otherwise, if you keep messing about with your files like that, you won't get the easy updates that git gives you.

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 00:58
by noobot
kali wrote:
noobot wrote:UPDATE:
I just fixed it from watching on GitHub.
https://github.com/OpenKore/openkore/co ... ad260c7952
This code update is the fix.

You can do one of the two things below: (Recommended option: 2)
1. Take whole GitHub update (and subsequently change/replace your config files for each bot).
2. Go to src/Network/Send/ServerType0.pm
- Go to Line 107
- You will see this line:

Code: Select all

'0362' => ['item_take', 'x4 a4', [qw(ID)]],
- Change it to:

Code: Select all

'0362' => ['item_take', 'a4', [qw(ID)]],
(Remove the 'x4 ' text from that line)

It will fix the problem.

You're welcome! :-)
The better option is 1. Otherwise, if you keep messing about with your files like that, you won't get the easy updates that git gives you.
Well, yes, of course! If there are more than one files to change, I prefer complete update too.
But I use and work with GitHub for a living, so I am comfortable making quick updates to my code without needing to pull from master every time.
To each his own way! Cheers!

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 02:36
by kali
Sounds good! :)

BTW we're looking for trustworthy mods to help us with the forums (esp in iRO section). Would you like to be one?

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 02:39
by Aappoolloo
kali wrote:Sounds good! :)

BTW we're looking for trustworthy mods to help us with the forums (esp in iRO section). Would you like to be one?
What are the qualifications? im interested.

Re: Failed to take <Item> issue (RE:Start)

Posted: 20 Jul 2017, 03:37
by kali
Aappoolloo wrote:
kali wrote:Sounds good! :)

BTW we're looking for trustworthy mods to help us with the forums (esp in iRO section). Would you like to be one?
What are the qualifications? im interested.
You need to show that you actually know what you're talking about. Git experience would be major bonus points.