Openkore.com

OpenKore Forums
It is currently 18 Oct 2019, 22:27

All times are UTC - 5 hours [ DST ]





Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 8 posts ] 
Author Message
 Post subject: r8977 - uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 22 Jun 2015, 02:24 
Offline
Plain Yogurt
Plain Yogurt

Joined: 20 May 2013, 02:00
Posts: 63
Just updated to revision 8977, I got this error multiple times.

Code:
Use of uninitialized value in string eq at src/ChatQueue.pm line 83.
Use of uninitialized value $user in string ne at src/ChatQueue.pm line 89.
Use of uninitialized value $ChatQueue::config{"callSign"} in quotemeta at src/ChatQueue.pm line 106.
Use of uninitialized value $user in hash element at src/ChatQueue.pm line 107.


Pretty sure it's from the update because ChatQueue.pm was updated in this revision. All my configs remained intact.


Last edited by Liposo on 22 Jun 2015, 11:26, edited 3 times in total.

Top
 Profile  
 
 Post subject: Re: uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 22 Jun 2015, 02:46 
Offline
Plain Yogurt
Plain Yogurt

Joined: 19 Apr 2011, 23:26
Posts: 63
did you change your config files? it may be caused by a new bug or by a change to your config file


Top
 Profile  
 
 Post subject: Re: uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 22 Jun 2015, 07:53 
Offline
Plain Yogurt
Plain Yogurt

Joined: 20 May 2013, 02:00
Posts: 63
No, I haven't made any change after updating to that revision.


Top
 Profile  
 
 Post subject: Re: r8977 - uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 23 Jun 2015, 00:58 
Offline
Plain Yogurt
Plain Yogurt

Joined: 19 Apr 2011, 23:26
Posts: 63
maybe somebody made a change that requires specific format of the config files. check for extra spaces or formatting problems


Top
 Profile  
 
 Post subject: Re: r8977 - uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 25 Jun 2015, 11:31 
Offline
Plain Yogurt
Plain Yogurt

Joined: 20 May 2013, 02:00
Posts: 63
Can anyone confirm this? Please.


Top
 Profile  
 
 Post subject: Re: r8977 - uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 04 Jul 2015, 04:24 
Offline
Plain Yogurt
Plain Yogurt

Joined: 20 May 2013, 02:00
Posts: 63
Bug still persists in r8978.


Top
 Profile  
 
 Post subject: Re: r8977 - uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 05 Jul 2015, 02:04 
Offline
Plain Yogurt
Plain Yogurt

Joined: 19 Apr 2011, 23:26
Posts: 63
download older revisions and check each to see exactly which revision broke it. then "diff" it to the previous revision and find the code that broke your config and fix it and ask a dev to commit your change to svn. you can find help on opk irc channel


Top
 Profile  
 
 Post subject: Re: r8977 - uninitialized value $ChatQueue::config{"callSign"}
PostPosted: 09 Jul 2015, 01:33 
Offline
Plain Yogurt
Plain Yogurt

Joined: 20 May 2013, 02:00
Posts: 63
It's exactly r8977 that the problem was introduced. It was no issue in the earlier revisions.
Also r8977 changelog clearly mentions that ChatQueue.pm was changed.

Quote:
Code cleanup in aisle /openkore/openkore/trunk/src/ChatQueue.pm !!
This commit is a perfect example showing why we MUST have both
use warnings;
use strict;
in every module to show that we both have bad code in there now, and to
prevent further bad code from being added without being noticed.

- Added "use warnings;"
- sub processChatCommand: In the "move" block, removed an if-elsif that
did *nothing* and has been in the codebase since the module was
created, nearly ELEVEN years ago!


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 8 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group