loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

Locked
Message
Author
Kaspy
OpenKore Monk
OpenKore Monk
Posts: 401
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#1 Post by Kaspy »

I noticed that in this twRO using exactly the same system that the PIN used in bRO...

Would not it be better to move everything receive.pm and send.pm?
Image

kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#2 Post by kLabMouse »

If it uses new Packet. Then Shure. But if it's working on top of Existing code, then no.

Maple
Noob
Noob
Posts: 14
Joined: 21 Mar 2013, 05:55
Noob?: No

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#3 Post by Maple »

cRO has PIN code too.
Using an Androin or iOS app lock to generate random 6-digits ligin PIN code.
Would rather to have a sample.

Kaspy
OpenKore Monk
OpenKore Monk
Posts: 401
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#4 Post by Kaspy »

Maple wrote:cRO has PIN code too.
Using an Androin or iOS app lock to generate random 6-digits ligin PIN code.
Would rather to have a sample.
This system seems to be different from the PIN used in bRO and twRO
Image

DrKN
Developers
Developers
Posts: 79
Joined: 06 Oct 2010, 09:22
Noob?: No

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#5 Post by DrKN »

Not sure about the loginPinCode right now because twRO just updated to a new version.

Kaspy
OpenKore Monk
OpenKore Monk
Posts: 401
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#6 Post by Kaspy »

Implement in r8518 by iMikeLance
Image

kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#7 Post by kLabMouse »

KeplerBR wrote:Implement in r8518 by iMikeLance
You guy's made ST0 unusable by others. With a few ST0 updates. (like the one that affected iRO and pRO ST).
Please, if it's something bound to packet ID's (like the one that affected iRO), please keep it out of ST0. Or check if OpenKore works on other Servers too.

ST0 is a core for all ST. So keep it clean as much as possible.

iMikeLance
Moderators
Moderators
Posts: 209
Joined: 01 Feb 2010, 17:37
Noob?: No
Location: Brazil - MG
Contact:

Re: loginPinCode in bRO.pm and twRO.pm!?Move to receive/send.pm?

#8 Post by iMikeLance »

kLabMouse wrote:
KeplerBR wrote:Implement in r8518 by iMikeLance
You guy's made ST0 unusable by others. With a few ST0 updates. (like the one that affected iRO and pRO ST).
Please, if it's something bound to packet ID's (like the one that affected iRO), please keep it out of ST0. Or check if OpenKore works on other Servers too.

ST0 is a core for all ST. So keep it clean as much as possible.
What's wrong with the latest commit?

EDIT: It wasn't any of our commits that caused that. Anyway, fixed it for iRO.

Revision: 8520
Author: marcelofoxes
Date: quinta-feira, 25 de abril de 2013 00:53:33
Message:
* fixed revision 8485 bug that affected iRO (and probably pRO too)

----
Modified : /openkore/trunk/src/Network/Receive/ServerType0.pm

Locked