RO Structs
Moderator: Moderators
Re: RO Structs
Double Posting....
Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.
Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.
-
- Super Moderators
- Posts: 801
- Joined: 06 May 2008, 12:47
- Noob?: No
Re: RO Structs
Could you post an example of this in the structs please?kLabMouse wrote:Double Posting....
Anyway, I think there is a big problem with Struct Align, because Client/Server is not compiled with "pragma pack".
Take a good look at "/* this+0x.... */" after each "char" or "unsigned char", sometimes next piece of data is not at +1 position.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
-
- Developers
- Posts: 1798
- Joined: 05 Dec 2008, 05:42
- Noob?: Yes
Re: RO Structs
Can it be fixed with inserting unused fields of necessary lengths?
-
- Super Moderators
- Posts: 801
- Joined: 06 May 2008, 12:47
- Noob?: No
Re: RO Structs
yea, i was thinking we could do this as last resort solution too.EternalHarvest wrote:Can it be fixed with inserting unused fields of necessary lengths?
But lets first confirm there is a problem before we even begin to think of solving it.
Btw, take a look at some pack strings in these files:
Code: Select all
src/Network/Send/kRO$ grep -r --include="*.pm" " x" *
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
Re: RO Structs
I've forgot where it was, but I know, there was some discussion on IRC in about 6~9mo ago about some packet, that had no good struct because of "char" type used in it.Technology wrote:Could you post an example of this in the structs please?
-
- Super Moderators
- Posts: 801
- Joined: 06 May 2008, 12:47
- Noob?: No
Re: RO Structs
Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
Re: RO Structs
So what are additional 2 bytes?Technology wrote:Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.
Re: RO Structs
Checked. No info on additional 2 bytes.kLabMouse wrote:So what are additional 2 bytes?Technology wrote:Btw, EQUIPMENTITEM_EXTRAINFO3's length in 02D0 on kRO seems to be 28 instead of 26 now.
But.. they added COSTUME item type.
So may-be it's related to it.
-
- Developers
- Posts: 1798
- Joined: 05 Dec 2008, 05:42
- Noob?: Yes
Re: RO Structs
kLabMouse wrote:But.. they added COSTUME item type.
Re: RO Structs
Uploading latest Works.
Packets up to 0x824 + HEADER's up to 0x83f
+ ENUM's
Packets up to 0x824 + HEADER's up to 0x83f
+ ENUM's
- Attachments
-
- packet_structs_and_enums.zip
- Packet Struct and ENUMS Up to May 2010
- (105.58 KiB) Downloaded 316 times