r8118 (shop_LockOnly)

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderator: Moderators

Locked
Message
Author
EternalHarvest
Developers
Developers
Posts: 1800
Joined: 05 Dec 2008, 05:42
Noob?: Yes

r8118 (shop_LockOnly)

#1 Post by EternalHarvest »

shopAuto_open can't really conflict with lockMap, so why?
Okay, but why changing default behaviour?
What happens now if you forgot to set lockMap or just warped to a location with no route to your lockMap?
Auto vending on multiple maps sounds like it already requires some scripting (or at least doCommands), why not change lockMap (free walking logic to a new location) or manually open the shop with it? Do you have any example where new code is really easier or more useful?

It may be a good idea to have a configurable control over this, but in that certain case (lockMap, shopAuto_open, openshop) it's not really understandable for me.

Also consistent naming (with inLockOnly, attackAuto_inLockOnly, avoidList_inLockOnly) isn't cool. Consistent lowercase-after-underscore theme neither.

if (!$cart{exists} && !$char->cartActive) {

That was already pointed on somewhere: that kind of check should be done inside cartActive().

kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: r8118 (shop_LockOnly)

#2 Post by kLabMouse »

God Damn. Who changed Default Behavior and Why?

EternalHarvest
Developers
Developers
Posts: 1800
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: r8118 (shop_LockOnly)

#3 Post by EternalHarvest »

I've got an insight by reading your post. Maybe it's Windows users who Randomly capitalize Letters because Their filesystem Doesn'T carE.

It doesn't really break anything, but one important question still needs an answer: What happens now if you're warped to a location with no route to your lockMap?

kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: r8118 (shop_LockOnly)

#4 Post by kLabMouse »

EternalHarvest wrote:I've got an insight by reading your post. Maybe it's Windows users who Randomly capitalize Letters because Their filesystem Doesn'T carE.

It doesn't really break anything, but one important question still needs an answer: What happens now if you're warped to a location with no route to your lockMap?

That Behavior should be checked out.

Be Default. Opening shop would be available anywhere where it's possible.
LockMap is only good for Constant Venders that do not leave the map.

Case 1)
Vender go to kafra; take goods; go to place where he sells; open shop;

Case 2)
Open shop in a location where is no kafra available; when he sells everything; he walk to LockMap and take goods from kafra; then go back to sell location

Case 3)
Playr does manually take goods; walk to point; open shop

EternalHarvest
Developers
Developers
Posts: 1800
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: r8118 (shop_LockOnly)

#5 Post by EternalHarvest »

kLabMouse wrote:LockMap is only good for Constant Venders that do not leave the map.

Why?

kLabMouse wrote:Case 1)
Vender go to kafra; take goods; go to place where he sells; open shop;

On the same map? Set lockMap with needed coordinates.

kLabMouse wrote:Case 2)
Open shop in a location where is no kafra available; when he sells everything; he walk to LockMap and take goods from kafra; then go back to sell location

Set lockMap and getAuto, go back and forth automatically. Actually, everything exactly the same as with the previous case.

kLabMouse wrote:Case 3)
Playr does manually take goods; walk to point; open shop

Open shop with command or set lockMap and open it automatically.

In all these cases, there is was conflict with lockMap. It's rather helpful to set lockMap when auto vending, and I want a counterexample.

More cases:
Case 4)
We need to change auto vending locations automatically. In this case, we just change lockMap and that's all.

Locked