About the r1841/r1844 Commit

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderators: Moderators, Developers

Message
Author
sofax222
Developers
Developers
Posts: 214
Joined: 24 Nov 2010, 03:08
Noob?: Yes

About the r1841/r1844 Commit

#1 Post by sofax222 »

In the r1841/r1844 Commit !
Adding the limit of "party leader specific commands".

I test this limit on twRO official server with running the RO client.
I could send a party request to player with none party leader!

I don't know why adding the limit of "party leader specific commands" into OpenKore ??

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: About the r1841/r1844 Commit

#2 Post by EternalHarvest »

sofax222 wrote:I don't know why adding the limit of "party leader specific commands" into OpenKore ??
Same there, it's not really necessary.

sofax222
Developers
Developers
Posts: 214
Joined: 24 Nov 2010, 03:08
Noob?: Yes

Re: About the r1841/r1844 Commit

#3 Post by sofax222 »

EternalHarvest wrote:
sofax222 wrote:I don't know why adding the limit of "party leader specific commands" into OpenKore ??
Same there, it's not really necessary.
Could I change it back ??

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: About the r1841/r1844 Commit

#4 Post by EternalHarvest »

Maybe we can have an option or a plugin for such restrictions.
I test this limit on twRO official server with running the RO client.
I could send a party request to player with none party leader!
Non-leader party members can invite to the party? If so, it should be reverted.

sofax222
Developers
Developers
Posts: 214
Joined: 24 Nov 2010, 03:08
Noob?: Yes

Re: About the r1841/r1844 Commit

#5 Post by sofax222 »

EternalHarvest wrote:Non-leader party members can invite to the party? If so, it should be reverted.
Actually !
The invited player could receive the "party invitaion" from non-leader party members with player's ID (The "sub sendPartyJoinRequest" in src/Network.Send/ServerType0.pm).

The invited player could not receive the "party invitaion" from non-leader party members with player's name (The "sub sendPartyJoinRequestByName" in src/Network.Send/ServerType0.pm).

Locked