r7025 | Can't call method "isOffMap"

This place is for Closed bug reports only. NOT for asking help!

Moderators: Moderators, Developers

Locked
Message
Author
User avatar
help_us
Testers Team
Testers Team
Posts: 106
Joined: 04 Apr 2008, 21:53
Noob?: No
Location: Asia
Contact:

r7025 | Can't call method "isOffMap"

#1 Post by help_us »

Code: Select all

OpenKore version what-will-become-2.1 (SVN Version) 
@ai_seq = follow
Network state = 5
Network handler = Network::XKore
SVN revision: 7025
No loaded plugins.

Error message:
Can't call method "isOffMap" on an undefined value at src/Network/Receive/ServerType0.pm line 909.

Stack trace:
Can't call method "isOffMap" on an undefined value at src/Network/Receive/ServerType0.pm line 909.
 at src/Network/Receive/ServerType0.pm line 909
	Network::Receive::ServerType0::actor_display('Network::Receive::ServerType22=HASH(0x369856c)', 'HASH(0x3c4fcf4)') called at src/Network/Receive.pm line 173
	Network::Receive::parse('Network::Receive::ServerType22=HASH(0x369856c)', '\x{ee}\x{2}\x{1a}\x{d}\x{3}\x{0}\x{96}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{a9}\x{f}\x{10}\x{0}R\x{6}8\x{8}\x{0}\x{0}H\x{0}\x{0}\x{0}\x{8}\x{0}\x{0}\x{0}\x{0}\x{0}^\x{e}\x{0}\x{0}\x{1}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{1}\x{18}\x{ce}0\x{5}\x{5}\x{0}U\x{0}\x{0}\x{0}') called at src/functions.pl line 1210
	main::parseIncomingMessage('\x{ee}\x{2}\x{1a}\x{d}\x{3}\x{0}\x{96}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{a9}\x{f}\x{10}\x{0}R\x{6}8\x{8}\x{0}\x{0}H\x{0}\x{0}\x{0}\x{8}\x{0}\x{0}\x{0}\x{0}\x{0}^\x{e}\x{0}\x{0}\x{1}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{0}\x{1}\x{18}\x{ce}0\x{5}\x{5}\x{0}U\x{0}\x{0}\x{0}') called at src/functions.pl line 556
	main::mainLoop_initialized() called at src/functions.pl line 70
	main::mainLoop() called at src/Interface.pm line 75
	Interface::mainLoop('Interface::Console::Win32=HASH(0x268857c)') called at openkore.pl line 96
	main::__start() called at start.pl line 125

Died at this line:
  	#  - actor packets not being parsed correctly
* 	if ($field->isOffMap($coordsFrom{x}, $coordsFrom{y}) || $field->isOffMap($coordsTo{x}, $coordsTo{y})) {
  		warning "Removed actor with off map coordinates: ($coordsFrom{x},$coordsFrom{y})->($coordsTo{x},$coordsTo{y}), field max: (" .$field->width(). "," .$field->height(). ")\n";

it happen after i entering map @cata1 (server auto-rename map(sometimes 0021@cata1, sometimes 0371@cata1, the number is random) and i dont have that map name, it never happen in previous revision)
Image
Image

Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: r7025 | Can't call method "isOffMap"

#2 Post by Technology »

hmm, is that an instanced map? Maybe we need to add support for that.
Yea, it didn't happen in previous revision, but can you bot when you don't have the field? (i'll take out this "error" later)

btw, how did you get to see this? 0021@cata1
- typing where?
- in console?
and are you sure there was a suffix "1"? wasn't it 0021@cata? (if this is the case than i can add the feature)

i guess:
002 (instance number)
1@cata1 (map name)

But how does the RO client, and thus we, know that the map is an instanced map?
- trough the @ symbol inside the name?
- trough instance packets? (02CD, ...)

could you make a console log with debug on?
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!

Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: r7025 | Can't call method "isOffMap"

#3 Post by Technology »

because i couldn't wait, i've already added:
- a soft fix for the method on undefined
- an experimental fix for instanced field map loading (assuming it is 1@cata and not 1@cata1)

TEST ASAP!!
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!

User avatar
help_us
Testers Team
Testers Team
Posts: 106
Joined: 04 Apr 2008, 21:53
Noob?: No
Location: Asia
Contact:

Re: r7025 | Can't call method "isOffMap"

#4 Post by help_us »

Code: Select all

[100/ 95] You use Soul Breaker (Lv: 10) on Monster Skeleton General (1) (Dmg:
8884) (delay: 41.4)
I lost my master
Trying to find lost master
Couldn't find master, giving up
Calculating route to find master: 0011@cata (127,13)
Found my master!
I lost my master
Trying to find lost master
Couldn't find master, giving up
Calculating route to find master: 0011@cata (164,29)
Calculating route to find master: 0011@cata (185,44)
Found my master!
Working, bot already reconize that map. thanks.
Image
Image

kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: r7025 | Can't call method "isOffMap"

#5 Post by kLabMouse »

Nice!

Fixed. Cosed.

Locked