Silver & Fire Arrowquiver creating with macro

[Andra]

As Topic say.
Thanks to Mushroom for the last missing Command
and Technology for the big improvements
And here we go Silverarrow:

Code: Select all

################# Triggerlist #####################
automacro SilverArrow {
	map alb2trea
	zeny > 60300
	timeout 170
	call Arrowbuy
}

automacro Quiver {
	map payon
	zeny > 30300
	timeout 190
	call getquiver
}



################ Macrolist ##############################

macro Arrowbuy {
	pause 1
	do move 73 67 alb2trea
	pause 1
	do talknpc 87 65 b b1,10000 e
	pause 1
	do talknpc 87 65 b b1,5000 e
	pause 1 
	do talknpc 59 69 c w1 r0 w1 n	
	pause 1
       	do storage add Silver Arrow 15000
	pause 3
	do storage close
	pause 2

	do talknpc 87 65 b b1,10000 e
	pause 1
	do talknpc 87 65 b b1,5000 e
	pause 1 
	do talknpc 59 69 c w1 r0 w1 n	
	pause 1
	do storage add Silver Arrow 15000
	pause 3
	do storage close
	pause 2
	do conf char 3
	pause 5
	do relog
release Arrowbuy
}


macro getquiver {
	pause 1
	do move 176 104 payon
	pause 1
	do talknpc 181 104 c w1 r1 w1 n	
	pause 1
	do storage get Silver Arrow 15000 
	pause 1
	do storage close
	pause 1
	do move 7 132 payon_in01
	pause 1
	do talknpc 5  134 c w1 c w1 c w1 c w1 r5 w1 c w1 r0 w1 c w1 c w1 r0 w1 c w1 c
	pause 1
	do move 176 104 payon
	pause 1

	do talknpc 181 104 c w1 r1 w1 n	
	pause 1
	do storage add Silver Arrow Quiver 100
	pause 2
	do storage get Silver Arrow 15000 
	pause 2
	do storage close
	pause 1
	do move 7 132 payon_in01
	pause 1
	do talknpc 5  134 c w1 c w1 c w1 c w1 r5 w1 c w1 r0 w1 c w1 c w1 r0 w1 c w1 c
	pause 1
	do move 176 104 payon
	pause 1
	do talknpc 181 104 c w1 r1 w1 n 	
	pause 1
	do storage add Silver Arrow Quiver 100
	do conf char 4
	pause 5
	do relog
release getquiver
}

And Fires:

Code: Select all

################# Triggerlist #####################

automacro FireArrow {
	map alb2trea
	zeny > 60300
	timeout 170
	call Arrowbuy
}

automacro Quiver {
	map payon
	zeny > 30300
	timeout 190
	call getquiver
}

################ Macrolist ##############################

macro Arrowbuy {
	pause 1
	do move 73 67 alb2trea
	pause 1
	do talknpc 87 65 b b2,10000 e
	pause 1
	do talknpc 87 65 b b2,5000 e
	pause 1 
	do talknpc 59 69 c w1 r0 w1 n	
	pause 1
       	do storage add Fire Arrow 15000
	pause 3
	do storage close
	pause 2
	do talknpc 87 65 b b2,10000 e
	pause 1
	do talknpc 87 65 b b2,5000 e
	pause 1 
	do talknpc 59 69 c w1 r0 w1 n	
	pause 1
	do storage add Fire Arrow 15000
	pause 3
	do storage close
	pause 2
	do conf char 3
	pause 5
	do relog
	pause 20
release Arrowbuy
}

macro getquiver {
	pause 1
	do move 176 104 payon
	pause 1
	do talknpc 181 104 c w1 r1 w1 n	
	pause 1
	do storage get Fire Arrow 15000 
	pause 1
	do storage close
	pause 1
	do move 7 132 payon_in01
	pause 1
	do talknpc 5  134 c w1 c w1 c w1 c w1 r5 w1 c w1 r0 w1 c w1 c w1 r0 w1 c w1 c
	pause 1
	do move 176 104 payon
	pause 1
	do talknpc 181 104 c w1 r1 w1 n	
	pause 1
	do storage add Fire Arrow Quiver 100
	pause 2
	do storage get Fire Arrow 15000 
	pause 2
	do storage close
	pause 1
	do move 7 132 payon_in01
	pause 1
	do talknpc 5  134 c w1 c w1 c w1 c w1 r5 w1 c w1 r0 w1 c w1 c w1 r0 w1 c w1 c
	pause 1
	do move 176 104 payon
	pause 1
	do talknpc 181 104 c w1 r1 w1 n 	
	pause 1
	do storage add Fire Arrow Quiver 100
	do conf char 4
	pause 5
	do relog
	pause 20
release getquiver
}

This give 1 Error at:

Code: Select all

do conf char 4 
pause 5
do relog
release getquiver

It cant release the macro because core relogs to other char before it release the macro...
Maybe i can remove anytime the relog command and add it in a seperate macro that start if the console write that char x switched at config or that macro xy is unloadet... but then another macro is runing that dont be released cause of the relog.

But these Error dont do anything to the Macro it works to 100% for me


To use the macro:
-get 1 char at best some1 with discount to the island at sunken ship near tooldealer / kafra (a 1 str char have enough weightcapacity for 15k arrows if he is undressed and dont wear any other items with him)
-another char with high str to payon (the char need to carry 15k arrows without get 90% overweight)
-change the x at "do conf char X" to your charnumber.(if you dont have the right char number you can look it by delete the number behind "char" at config.txt and start core)
-remove the lockmap from the Config.txt if you have set 1

hope this can help you at your 24/7 hunters

feel free to reply any ideas to the macro

[Technology]

Yes, i had this error too, when i was testing some shopping macro.
Its nothing bad, except for that it uses up console space.
To get rid of it, you have to replace: (look below for a better solution)

Code: Select all

do talknpc 87 65 #sequence

with

Code: Select all

do talk @npc(87 65)

Same goes for selling items.

or you could do this (better):

Code: Select all

#usage: do talknpc 87 65 b b(<store item #>),(<amount>) e
#for fire:
do talknpc 87 65 b b3,15000 e
#for silver:
do talknpc 87 65 b b2,15000 e

Suggestions:
1) So your bot doesn't has to walk between those 2 npc's.

Code: Select all

do move 73 67 alb2trea

2) And why not buy 15k arrows at once? Is there a cap on buying more than 10k at your server? (not on RMS atleast)
3) Now you are getting 15k ele arrows = 3k weight, you could have a constant like $maxweight = x where you put the maxweight for your character, that has the least amount of maxweightlimit, and make a formula to get as much arrows as you can at once.
4) or you could have a constant, where you put in the amount of total arrowquivers you want, and make your vender loop buy & store when done you can switch to your other char and make him loop the arrows to quiver macro.

[Andra]

yes at most servers i know 10k is buying cap don know why
you say :"do talknpc 87 65 b b3,15000 e" i bet the "b" is buy and "b3" buyitem3 and "e" end? (good to remind it for future macros)
i add your part of npc sequence in the macro i think iam close to get rid of the cant release error. Hopefull its all without any error till monday.

Your idea about a $maxweight variable and a repeat loop function sounds great but will me cost some sleepless nights to test out but first i remove the unneedet errors. it where take me longer time to get a weightvariable



a thing i add soon to the trigger is a zenny amount to not start macro at low zennys

the macro was at first made for high aspd archers shooting close 30k arrows over night and day while iam at work and the cap of 30k items in kafra store dont make it better T_T

btw: first i need to get core loot items for sale cause i let run the macro till zenny went out

iam not sure but i think there was a function at config.txt to log the char out if any items reach a setted ammount i bet it was only if flywings reach 0
but...
i got a idea to get a specific amount of quivers but the macro dont trigger with it

Code: Select all

################# Triggerlist #####################
automacro SilverArrow {
	map alb2trea
	zeny > 60300
	storage "Silver Arrow Quiver" < 310### anything missing here
	timeout 170
	call Arrowbuy
}

automacro Quiver {
	map payon
	zeny > 30300
	storage "Silver Arrow Quiver" < 310 ###anything missing here
	timeout 190
	call getquiver
}

this is from macro manual:

Code: Select all

 storage "<item>" <condition> <amount> [, ...]
    triggers when you have <condition> <amount> of <item> in your storage. 
    Comma-separated arguments are treated as OR conditions. 
    Multiple lines are treated as AND conditions.

maybe its some with the [, ...] at the end of storagepart

thank you Technology for your idea and improvement

[Technology]

Oh lol, i did not know that you had an error with releasing the macro.
But now you said so, and i looked into this.
The mistake is that you cannot lock a macro, you can only lock an automacro.
And change the order of the 'do relog' and the 'release' for the other problem.
so replace for both macro's:

Code: Select all

do conf char 4 
pause 5
do relog
release getquiver #<<------- macro (wrong)

by

Code: Select all

do conf char 4 
pause 5
release Quiver #<<------- automacro (right)
do relog

As for the automacro part, i suggest you to add 'exclusive 1' not to have other macro's interrupt your current one:

Code: Select all

automacro FireArrow {
   map alb2trea
   zeny > 60300
   storage "Silver Arrow Quiver" < 310
   exclusive 1
   call Arrowbuy
}

There is 1 problem tho, the automacro won't get activated when the storage hasn't been opened before in the session yet.
But do these changes already and we can come back to that part later.

[tatamiusuka]

Emm, may i know how actually this marco work? I copy the whole code sliver quiver code to my marco.txt but it wont run, it only will login my character and sit down there. Beside that, I trying to make normal arrow quiver and my code is at below, same error come out.(I mean my char only will sit there doing ntg) Help!!

Code: Select all

################# Triggerlist #####################
automacro Arrow {
   map payon
   zeny > 60300
   timeout 170
   call Arrowbuy
}

automacro Quiver {
   map payon
   zeny > 30300
   timeout 190
   call getquiver
}



################ Macrolist ##############################

macro Arrowbuy {
   pause 1
   do move 159 96 payon
   pause 1
   do talknpc 87 65 b b1,10000 e
   pause 1
   do talknpc 87 65 b b1,5000 e
   pause 1 
   do talknpc 59 69 c w1 r0 w1 n   
   pause 1
          do storage add Arrow 15000
   pause 3
   do storage close
   pause 2

   do talknpc 87 65 b b1,10000 e
   pause 1
   do talknpc 87 65 b b1,5000 e
   pause 1 
   do talknpc 59 69 c w1 r0 w1 n   
   pause 1
   do storage add Arrow 15000
   pause 3
   do storage close
   pause 2
   do conf char 3
   pause 5
   do relog
release Arrowbuy
}


macro getquiver {
   pause 1
   do move 176 104 payon
   pause 1
   do talknpc 181 104 c w1 r1 w1 n   
   pause 1
   do storage get Arrow 15000 
   pause 1
   do storage close
   pause 1
   do move 7 132 payon_in01
   pause 1
   do talknpc 5  134 c w1 c w1 c w1 c w1 r5 w1 c w1 r0 w1 c w1 c w1 r0 w1 c w1 c
   pause 1
   do move 176 104 payon
   pause 1

   do talknpc 181 104 c w1 r1 w1 n   
   pause 1
   do storage add Arrow Quiver 100
   pause 2
   do storage get Arrow 15000 
   pause 2
   do storage close
   pause 1
   do move 7 132 payon_in01
   pause 1
   do talknpc 5  134 c w1 c w1 c w1 c w1 r5 w1 c w1 r0 w1 c w1 c w1 r0 w1 c w1 c
   pause 1
   do move 176 104 payon
   pause 1
   do talknpc 181 104 c w1 r1 w1 n    
   pause 1
   do storage add Arrow Quiver 100
   do conf char 4
   pause 5
   do relog
release getquiver
}