Re: Moving to GitHub
Posted: 04 Mar 2016, 10:12
By the way, hopefully you've seen our discussion about the new code review process: https://github.com/OpenKore/openkore/issues/9 :)
My github account is "snop222" !!itsrachelfish wrote:Well, I'll need to know what your github account is. I tried "sofax222" and "sofax" but it wasn't either of thosesofax222 wrote: Commit failed (details follow):
Access to '/OpenKore/openkore/!svn/act/a3b50695-c1dd-e647-b25c-05daf3acf7df'
forbidden
How can I be added into the members of Github/Openkore ??
Once we have your username, any of the project admins can add you as a developer to the project. But you don't even need to be an official developer to the project to contribute on GitHub. Anyone can make a fork of the project in their own account, make commits, and then submit a pull request to be approved in the official repo.
Edit: I've updated my original post to be more clear. Hope that helps /no1
Ok !! Now I got a fork from the Openkore project.itsrachelfish wrote:Well, I'll need to know what your github account is. I tried "sofax222" and "sofax" but it wasn't either of thosesofax222 wrote: Commit failed (details follow):
Access to '/OpenKore/openkore/!svn/act/a3b50695-c1dd-e647-b25c-05daf3acf7df'
forbidden
How can I be added into the members of Github/Openkore ??
Once we have your username, any of the project admins can add you as a developer to the project. But you don't even need to be an official developer to the project to contribute on GitHub. Anyone can make a fork of the project in their own account, make commits, and then submit a pull request to be approved in the official repo.
Edit: I've updated my original post to be more clear. Hope that helps /no1
Hey there, I checked out your changes and everything looks good. Your pull request was merged into the main project. :)sofax222 wrote:Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?
Yes !! I Got it !!itsrachelfish wrote:Hey there, I checked out your changes and everything looks good. Your pull request was merged into the main project.sofax222 wrote:Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?
Also, I've added you to the GitHub organization as a developer, check your email for confirmation.
Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).
If you're still curious how someone would be able to checkout your forked code from the official project, they'd just have to make a local branch with your repo as the remote. This is explained on GitHub by follow these steps:
Some thing stranger ......itsrachelfish wrote:Hey there, I checked out your changes and everything looks good. Your pull request was merged into the main project.sofax222 wrote:Ok !! Now I got a fork from the Openkore project.
After my own commit, and create a pull request to the official repo.
But Now !! How to re-checkout from the official project into my fork ?
Also, I've added you to the GitHub organization as a developer, check your email for confirmation.
Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).
Sorry, question again....itsrachelfish wrote:Now that you have commit access, you can make your own branch in the main project repo and submit pull requests that way (instead of using a fork, if you prefer).
If you're still curious how someone would be able to checkout your forked code from the official project, they'd just have to make a local branch with your repo as the remote. This is explained on GitHub by follow these steps:
You'll probably want to spend some time learning how git works, there are a lot of great resources out there including the official Git documentation and YouTube tutorials. I sent you that screenshot because it explains the steps required for someone to take the master openkore branch and apply your patch for testing.sofax222 wrote:Sorry, question again....
I work around on my fork of Openkore.....
But I can not find the "Merge pull request" function as your captured image, where is it ??
Ah, Sorry !! Very Sorry !! I think I had a mistake !!itsrachelfish wrote:Earlier today you merged two pull requests:
https://github.com/OpenKore/openkore/pull/34
https://github.com/OpenKore/openkore/pull/35
Did you test these changes in game before merging them? The point of making pull requests is so that developers can review and test changes before they are incorporated into the main project.
Dear itsrachelfish:itsrachelfish wrote:Did you test these changes in game before merging them? The point of making pull requests is so that developers can review and test changes before they are incorporated into the main project.