Fixed bug when received 00C6 without NPC Information

[UltimaWeapon]

Below is a topic that report this bug.

http://forums.openkore.com/viewtopic.php?f=56&t=6821

The bug in that topic is because kore received 00C6 (NPC Buy List) after received 00B6 (NPC Cancel). When kore received 00B6. %talk will be undefined and cause this bug appeared.

This is a patch for fixed this bug.

Code: Select all

Index: src/Network/Receive.pm
===================================================================
--- src/Network/Receive.pm	(revision 6825)
+++ src/Network/Receive.pm	(working copy)
@@ -4265,8 +4265,10 @@
 		debug "Item added to Store: $store->{name} - $price z\n", "parseMsg", 2;
 		$storeList++;
 	}
-
-	my $name = getNPCName($talk{ID});
+	
+	# Real RO client can be receive this message without NPC Information. We should mimic this behavior.
+	my $name = (defined $talk{ID}) ? getNPCName($talk{ID}) : 'Unknown';
+	
 	$ai_v{npc_talk}{talk} = 'store';
 	# continue talk sequence now
 	$ai_v{'npc_talk'}{'time'} = time;

Please commit it.

Thank you.

[windows98SE]

UltimaWeapon, i love you

[fChopin]

in this subrutine
$name is the NPCID right ?
i've found that $name use only once when OpenKore
want to show the NPCID on it's console.

with my little idea

#my $name = getNPCName($talk{ID});
message TF("---------- Store List-----------\n" ."# Name Type Price\n"), "list";

i've used this way to bypass this bug for 2-3 days

and thx Ultima Weapon
for the better way

[kLabMouse]

Developers, Please Commit it.
Thanks.

[h4rry84]

Committed ,