Still have issue's with target_hp in partySkill Heal

Forum closed. All further discussion to be discussed at https://github.com/OpenKore/

Moderators: Moderators, Developers

Message
Author
IKnewThat
Noob
Noob
Posts: 2
Joined: 30 Nov 2008, 07:37
Noob?: Yes

Still have issue's with target_hp in partySkill Heal

#1 Post by IKnewThat »

in regards to this fixed bug
http://forums.openkore.com/viewtopic.php?f=61&t=11746

I'm still finding issue's with my target_hp

I have tried tweaking the fields shown in the listed fix but to no avail, whenever I try to use target_hp my priest bot does not heal.

I tried removing the target_hp condition to see if the bot could heal, the moment I reloaded config the priest bot would heal the target just fine, but once I put the target_hp field in the healing stops, no matter what criteria I set.

I'm using the latest version of openkore which was posted at http://openkore.collectskin.com/ and I'm not sure if I figured out how to get the updater to work but I have tortoiseSVN setup.

Code: Select all

# Target is Actor::Player in our Party
      } elsif ($char->{party} && $char->{party}{users}{$id}) {
         # Fix Heal when Target HP is not set yet.
         return 0 if (!defined($player->{hp}) || $player->{hp} == 0);
         # return 0 if ($char->{party}{users}{$id}{hp} == 0);
         if ($config{$prefix."_hp"} =~ /^(.*)\%$/) {
            return 0 if (!inRange(percent_hp($player), $1));
            # return 0 if (!inRange(percent_hp($char->{party}{users}{$id}), $1));
         } else {
            return 0 if (!inRange($player->{hp}, $config{$prefix . "_hp"}));
            # return 0 if (!inRange($char->{party}{users}{$id}{hp}, $config{$prefix . "_hp"}));
         }
I tried swapping the commented lines to see if my problem could get fixed but neither has seemed to get my target_hp field to work properly.

Again the slave heals the master just fine if target_hp is unused, but when trying to use target_hp <70% it stops working, no matter how I setup the criteria.

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Still have issue's with target_hp in partySkill Heal

#2 Post by EternalHarvest »

Can you see party member's hp with "party" command?

Locked