Openkore.com

OpenKore Forums
It is currently 14 Nov 2019, 14:58

All times are UTC - 5 hours [ DST ]





Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 7 posts ] 
Author Message
 Post subject: introduced in: r7640 | affects: pRO,tRO | desc: item error
PostPosted: 02 Feb 2011, 23:52 
Offline
Noob
Noob

Joined: 22 Dec 2010, 09:56
Posts: 5
EDIT (by Technology): dev description of problem & solution

I'm having trouble viewing my items for some reason it suddenly becomes like this. I already update my openkore to the latest version but it still the same and adjusted the char block size to 112.
Image

Hope you can help me.


Top
 Profile  
 
 Post subject: Re: Item Error
PostPosted: 03 Feb 2011, 08:18 
Offline
Human
Human
User avatar

Joined: 03 Feb 2011, 08:10
Posts: 22
There are some new items needed to be updated in items.txt. You can either edited it manuallly in \tables\iRO\items.txt (I assumed you in iRO) or just wait someone updated the new table for us. :)


Top
 Profile  
 
 Post subject: Re: Item Error
PostPosted: 03 Feb 2011, 09:20 
Offline
Noob
Noob

Joined: 28 Jan 2011, 14:38
Posts: 1
this is not table issue. there are some error in src\Network\Receive\ServerType0.pm.
i also have this error but it was solved by edit some part of codes

(rev7643)
Line 1993:
Line 3638:
Line 6477:
replace
Code:
$psize = 28;

with
Code:
$psize = 26;


PS I was on tRO


Top
 Profile  
 
 Post subject: Re: Item Error
PostPosted: 03 Feb 2011, 10:16 
Offline
Super Moderators
Super Moderators
User avatar

Joined: 06 May 2008, 12:47
Posts: 801
Lightwave wrote:
this is not table issue. there are some error in src\Network\Receive\ServerType0.pm.
i also have this error but it was solved by edit some part of codes

(rev7643)
Line 1993:
Line 3638:
Line 6477:
replace
Code:
$psize = 28;

with
Code:
$psize = 26;


PS I was on tRO

Yep that pretty much nailed the problem, its the usual story, it seems a recent commit (r7640) to fix one serverType (twRO) broke the others (tRO, pRO, etc...)
Don't assume that when one ST changes a struct that others will immediatly change as well, this is why we have twRO.pm and the like.

For proper interservertype compatibility, instead I suggest that ServerType0.pm adopts Sakexe0.pm's "items_(non)stackable" handling.
There, we deal with the $psize servertype specific cruft (in terms of the packet's inner struct's length & unpackstring) in a cleaner, reusable and serverType overridable manner.
(ex. in Sakexe0.pm, RagexeRE_2010_06_29a.pm overrides the "26 length inner struct" with an "28 length inner struct" for items_nonstackable type3)
(however still a bit hacky, its far better than what we have now, until we get a full blown struct un-packer)


Since this a src problem, i changed the title and moved this to bug reports.


It should be fairly easy to port Sakexe0.pm's "items_(non)stackable" handling to ST0,
so this task is open for anyone who wants to give it a try. ;)

_________________
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!


Top
 Profile  
 
 Post subject: Re: Item Error
PostPosted: 03 Feb 2011, 21:43 
Offline
Human
Human

Joined: 28 Jan 2011, 03:05
Posts: 26
Lightwave wrote:
this is not table issue. there are some error in src\Network\Receive\ServerType0.pm.
i also have this error but it was solved by edit some part of codes

(rev7643)
Line 1993:
Line 3638:
Line 6477:
replace
Code:
$psize = 28;

with
Code:
$psize = 26;


PS I was on tRO



tried it and it works on pRO Valkyrie too.. +1reps to you mate.


Top
 Profile  
 
 Post subject: Re: introduced in: r7640 | affects: pRO,tRO | desc: item error
PostPosted: 23 Feb 2011, 09:56 
Offline
Developers
Developers

Joined: 06 Oct 2010, 09:22
Posts: 79
Please follow twRO.pm in Network\Receive and you will get the solution


Top
 Profile  
 
 Post subject: Re: introduced in: r7640 | affects: pRO,tRO | desc: item error
PostPosted: 17 Apr 2012, 03:08 
Offline
Noob
Noob

Joined: 25 Nov 2010, 02:15
Posts: 8
I looked at servertype0.pm and couldn't find anything related to $psize = 28;

Anything else I could do to remedy unknown items?


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 7 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group