r7164 | bug in Misc::calcRectArea

[allanon256]

I noticed that runFromTarget was failing to run properly in some circumstances, and found that there is a bug in Misc::calcRectArea. Specifically, the code is checking for non-walkable tiles on the left side when it is supposed to be checking the right side.

I've fixed the issue for myself, and figured others might benefit from the fix as well. Here is a patch to fix the issue:

Code: Select all

--- src/Misc.pm (revision 7164)
+++ src/Misc.pm (working copy)
@@ -511,7 +511,7 @@
                }
        }
        for (my $y = $bottomRight{y} + 1; $y < $topRight{y}; $y++) {
-               if ($field->isWalkable($topLeft{x}, $y)) {
+               if ($field->isWalkable($topRight{x}, $y)) {
                        push @walkableBlocks, {x => $topRight{x}, y => $y};
                }
        }


[Technology]

thanks allanon256,
its in svn now

[kali]

Wow thanks, good catch!