iRO Tables are not UTF-8 encoded

[itsrachelfish]

Commit 8036 was submitted by jackyan 3 days ago. It was supposedly made to update OpenKore's extremely outdated tables for iRO. A valiant effort, unfortunately he didn't even bother to test his changes before committing.

Config 'serverType' set to iRO (was 0)
Config 'charBlockSize' set to 116 (was not set)
Config 'serverEncoding' set to Western (was not set)
Loading tables\iRO\recvpackets.txt...
Loading tables\cities.txt...
Loading tables\commanddescriptions.txt...
Loading tables\directions.txt...
Loading tables\elements.txt...
Loading tables\emotions.txt...
Loading tables\equiptypes.txt...
Loading tables\haircolors.txt...
Loading tables\headgears.txt...
Loading tables\iRO\items.txt...
The file tables/iRO/items.txt must be valid UTF-8 encoded, which it is
currently not. To solve this prolem, please use Notepad
to save that file as valid UTF-8.

Oops!

On windows the only affected file is itemsdescriptions.txt, however on linux items.txt, itemsdescriptions.txt, resnametable.txt, maps.txt, and quests.txt all raise the same error. Not sure the reason for this discrepancy, maybe because I downloaded the windows version from collectskin and the linux version over SVN?

If you're interested, I wrote a little python script to check the encoding for all the iRO table files:

Code: Select all

python encoding.py
EUC-KR - tables/iRO/quests.txt
ISO-8859-2 - tables/iRO/maps.txt
EUC-KR - tables/iRO/resnametable.txt
EUC-JP - tables/iRO/skillnametable.txt
ISO-8859-2 - tables/iRO/itemsdescriptions.txt
ascii - tables/iRO/skillsdescriptions.txt
ascii - tables/iRO/itemslots.txt
None - tables/iRO/npcs.txt
None - tables/iRO/monsters.txt
ascii - tables/iRO/statusnametable.txt
UTF-8 - tables/iRO/spells.txt
ascii - tables/iRO/itemslotcounttable.txt
EUC-KR - tables/iRO/items.txt
ascii - tables/iRO/recvpackets.txt
ascii - tables/iRO/skillssp.txt

Huh! skillsdescriptions.txt is not UTF-8 yet it loads fine. I even tested it in game by typing 'skills desc 1' which showed the skill description properly. I'm guessing only files with korean characters need to be UTF-8?

After that I modified my little python script to convert all non-ascii files to UTF-8. And woah! I actually tested before committing.