r8485 and up: Kore hangs on Character Select on iRO
Posted: 18 Apr 2013, 05:17
After relocating the repository url and updating all the way to r8509, openkore hangs on the Character Selection server.
I was on the latest on the old repository, r8448, so I skipped along, looking for changes to /src/Network/Receive/ServerType0.pm in between, and isolated the start of the problem to r8485.
This involves a commit for twRO's Character Selection packets, but now, seemingly affects ALL servers, because of something altered in ServerType0.pm that ALL servers use.
I can't easily deduce where the change is, because there is so many extraneous whitespace changes in the file in this commit!
The svn username was sofax222 -- please review your commit in 8485, and fix this issue so ALL THE OTHER SERVERS can connect.
I fear that the repository URL relocation is shielding this change from a great many users, so please get this fixed before we have thousands of "Eye cant connect!!! hlp plz!!!!" trash posts that will tie up the mods needlessly.
Furthermore, changes to the base ServerType should always be made with care ... given the large amount of whitespace changes made willy-nilly with not mention of a "cleanup" in the commit comments leads me to believe that the commit wasn't reviewed over as a diff before it was committed.
I was on the latest on the old repository, r8448, so I skipped along, looking for changes to /src/Network/Receive/ServerType0.pm in between, and isolated the start of the problem to r8485.
This involves a commit for twRO's Character Selection packets, but now, seemingly affects ALL servers, because of something altered in ServerType0.pm that ALL servers use.
I can't easily deduce where the change is, because there is so many extraneous whitespace changes in the file in this commit!
The svn username was sofax222 -- please review your commit in 8485, and fix this issue so ALL THE OTHER SERVERS can connect.
I fear that the repository URL relocation is shielding this change from a great many users, so please get this fixed before we have thousands of "Eye cant connect!!! hlp plz!!!!" trash posts that will tie up the mods needlessly.
Furthermore, changes to the base ServerType should always be made with care ... given the large amount of whitespace changes made willy-nilly with not mention of a "cleanup" in the commit comments leads me to believe that the commit wasn't reviewed over as a diff before it was committed.