[patch] attackSkillSlot timeout, target_timeout not working

[Nobbi128]

Hi,
I noticed that the "timeout" attribute of "attackSkillSlot"
did not work.

I wanted to do a "Magnum Break" every 10 seconds
(because your weapon has the fire attribute then),
but Kore ignored the "timeout".

attackSkillSlot Magnum Break {
lvl 10
sp > 30
timeout 10
}

The reason for this problem is, that the time is not recorded,
when a skill is used. After I made the following change in
"openkore/src/AI.pm" it worked:

sub ai_skillUse {
...
$ai_v{$args{prefix}."_time"} = time; # <-- added by me
AI::queue("skill_use", \%args);
}

I am not sure if this is the right position to record the skill-use
time, but somewhere it has to be done. "target_timeout" does
also not work, but i didn't investigate that.

[Technology]

I confirm and are aware that this is also the case for other types of 'skill block'.

Where to start the timer for the timeout is a very good question.
Atm, for most (if not all) 'skill blocks', the timer starts when kore receives the packet.
So go figure what happens if you lag, kore will spam skillUse packets.
On my copy of SVN trunk, i have timeouts based on both sent (trough AI) and received packets.

Its not a good idea to try and fix all of this since the old kore model is well...

[Darki]

So, is there any fix on this? I mean, for the target_timeout and stuff. I had to use Nobbi128's fix because my bot was doing Holy Cross at inhuman speed and some people were suspecting, but I'd like to fix it on the target thing too, for the buffs.

[EternalHarvest]

That stuff happens because every processSomething in CoreLogic is assumed to set the triggering time for a block by itself.
Maybe with some blocks it isn't set at all.

[EternalHarvest]

Fixed in r7670.