Bug: skillsAddAuto_list, If I use chinese skill name.

[woozc]

Bug: if I use chinese skill name in skillsAddAuto_list, the OP could not get correct name to auto add point. So I change one place to fix that.

--------------CoreLogic.pm-------------------
##### AUTO SKILLS RAISE #####
sub processAutoSkillsRaise {
if (!$skillChanged && $config{skillsAddAuto}) {
# Split list of skills and levels
my @list = split / *,+ */, ($config{skillsAddAuto_list});

foreach my $item (@list) {
# Split each skill/level pair
my ($sk, undef, $num) = $item =~ /^(.*?)( (\d+))?$/;
$num = 1 if (!defined $num);
my $skill = new Skill(name => $sk);
.......
.....
....
-----------------------------------------------
Origin: my $skill = new Skill(auto => $sk);

[littlewens]

Before modified, I can add a skill by typing skill code, but can't add a skill by typing skill name.

After modified, I can add a skill by typing skill name, but can't add a skill by typing skill code.

I think the latter way is much better. Thank you very much! =)

To the Developers:
Can this commit to SVN?

[h4rry84]

none is better. it must be fixed.

[isieo]

please make a diff patch.

[woozc]

I add some codes!
=================CoreLogic.pm==================
##### AUTO SKILLS RAISE #####
sub processAutoSkillsRaise {
if (!$skillChanged && $config{skillsAddAuto}) {
# Split list of skills and levels
my @list = split / *,+ */, ($config{skillsAddAuto_list});

foreach my $item (@list) {
# Split each skill/level pair
my ($sk, undef, $num) = $item =~ /^(.*?)( (\d+))?$/;
$num = 1 if (!defined $num);

my $skill = new Skill(auto => $sk);

if (!$skill->getIDN()) {
$skill = new Skill(handle => $sk);
if (!$skill->getIDN()) {
$skill = new Skill(name => $sk);
if (!$skill->getIDN()) {
error TF("Unknown skill '%s'; disabling skillsAddAuto\n", $sk);
$config{skillsAddAuto} = 0;
last;
}
}
}
================================================
use those in skillsAddAuto_list
Merchant' skill
37 ==== yes
MC_DISCOUNT ==== yes
低價買進 ===== yes.......(Big5 skill name)

[sli]

please make a diff patch.

[littlewens]

Here:

Code: Select all

Index: CoreLogic.pm

===================================================================

--- CoreLogic.pm	(revision 6532)

+++ CoreLogic.pm	(working copy)

@@ -1905,18 +1905,25 @@

 sub processAutoSkillsRaise {
 	if (!$skillChanged && $config{skillsAddAuto}) {
 		# Split list of skills and levels
-		my @list = split / *,+ */, lc($config{skillsAddAuto_list});
+		my @list = split / *,+ */, ($config{skillsAddAuto_list});
 
 		foreach my $item (@list) {
 			# Split each skill/level pair
 			my ($sk, undef, $num) = $item =~ /^(.*?)( (\d+))?$/;
 			$num = 1 if (!defined $num);
+
 			my $skill = new Skill(auto => $sk);
 
 			if (!$skill->getIDN()) {
-				error TF("Unknown skill '%s'; disabling skillsAddAuto\n", $sk);
-				$config{skillsAddAuto} = 0;
-				last;
+				$skill = new Skill(handle => $sk);
+				if (!$skill->getIDN()) {
+					$skill = new Skill(name => $sk);
+					if (!$skill->getIDN()) {
+						error TF("Unknown skill '%s'; disabling skillsAddAuto\n", $sk);
+						$config{skillsAddAuto} = 0;
+						last;
+					}
+				}
 			}
 
 			my $handle = $skill->getHandle();

[Technology]

I have tested on latest svn with korean names and it worked so i assume this is also fixed.