Something wrong in r8141 commit !!

This place is for Closed bug reports only. NOT for asking help!

Moderators: Moderators, Developers

Post Reply
Message
Author
sofax222
Developers
Developers
Posts: 214
Joined: 24 Nov 2010, 03:08
Noob?: Yes

Something wrong in r8141 commit !!

#1 Post by sofax222 »

The r8141 commited by marcellofoes seems something wrong !
The adding code is for checking the "leader-only party commands".
But these codes:

Code: Select all

   } elsif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {
.......

Make the followings "elsif"'s never be excuted !!

iMikeLance
Moderators
Moderators
Posts: 209
Joined: 01 Feb 2010, 17:37
Noob?: No
Location: Brazil - MG
Contact:

Re: Something wrong in r8141 commit !!

#2 Post by iMikeLance »


EternalHarvest
Developers
Developers
Posts: 1800
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Something wrong in r8141 commit !!

#3 Post by EternalHarvest »

"kick" and "leader" still seem to be broken.

iMikeLance
Moderators
Moderators
Posts: 209
Joined: 01 Feb 2010, 17:37
Noob?: No
Location: Brazil - MG
Contact:

Re: Something wrong in r8141 commit !!

#4 Post by iMikeLance »

Working fine:

Code: Select all

party request 1
You are the party leader.
TestPlayer1 entrou no seu grupo '"Test Party"'
TestPlayer1 aceitou seu pedido.
party
----------Grupo-----------
"Test Party"
#      Nome                  Mapa                   Online    HP
0  (A) TestKore          prontera      181, 100 Sim       540/540 (100%)
1      TestPlayer1                 prontera      182, 97  Sim       13480/13480
(100%)
--------------------------
party leader 1
You are the party leader.
New party leader: TestPlayer1
New party leader: TestKore
party kick 1
You are the party leader.
EXP do grupo Dividida Individualmente.
Party TestPlayer1 left the party (kicked)
EXP do grupo Dividida Individualmente.


Code: Select all

party leader 1
You are the party leader.
New party leader: TestPlayer1
party kick 0
Error in function 'party kick'
You must be the party leader in order to use this !
party leader 0
Error in function 'party leader'
You must be the party leader in order to use this !
party share 0
Error in function 'party share'
You must be the party leader in order to use this !


But at least in bRO party request and friend request are broken. When you send party request kore actually sends a friend request and when sending friend request i got a DC. I can fix that but i'm downloading iRO to test it it's broken there too.

5e13ct
Plain Yogurt
Plain Yogurt
Posts: 51
Joined: 02 Sep 2012, 11:09
Noob?: No
Location: Brazil - PR

Re: Something wrong in r8141 commit !!

#5 Post by 5e13ct »

sofax222 wrote:The r8141 commited by marcellofoes seems something wrong !
The adding code is for checking the "leader-only party commands".
But these codes:

Code: Select all

   } elsif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {
.......

Make the followings "elsif"'s never be excuted !!


} elseif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {

iMikeLance
Moderators
Moderators
Posts: 209
Joined: 01 Feb 2010, 17:37
Noob?: No
Location: Brazil - MG
Contact:

Re: Something wrong in r8141 commit !!

#6 Post by iMikeLance »

5e13ct wrote:
sofax222 wrote:The r8141 commited by marcellofoes seems something wrong !
The adding code is for checking the "leader-only party commands".
But these codes:

Code: Select all

   } elsif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {
.......

Make the followings "elsif"'s never be excuted !!


} elseif ($arg1 eq "request" || $arg1 eq "share" || $arg1 eq "kick" || $arg1 eq "leader") {



http://www.devdaily.com/blog/post/perl/perl-if-else-elsif-syntax-example wrote:The Perl "else if" syntax (elsif)

In Perl the "else if" syntax actually uses the elsif keyword. Here's some example code showing this syntax:

Code: Select all

if ($condition1)
{
  # do something
}
elsif ($condition2)
{
  # do something else
}
elsif ($condition3)
{
  # yada
}
else
{
  # do the 'else' thing
}


Post Reply