Stop misusing config.txt's block format

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

hakore
Super Moderators
Super Moderators
Posts: 200
Joined: 16 May 2008, 08:28
Noob?: No

Re: Stop misusing config.txt's block format

#11 Post by hakore »

isieo, it is clearly our fault for being inactive while this change was made. But I guess, and I hope, it is not too late to voice out our side on this.

--

BTW, if we revert the default config.txt to use the old format as you proposed, the internal code that allows the use of teleportAuto_ in block format is rather useless. It's like a secret feature that can be used only by a few who "knows". It is better scrapped, isn't it?

Cosmetic changes "should" be implemented publicly, as what was done when Joseph devised the curly bracket format in the first place. No one (or almost no one) uses the old "config_0_attribute" syntax anymore.

Therefore, I can see only two options here:

1. We push through with the cosmetic improvement of config.txt, but change the syntax to not use curly brackets.

or

2. We drop this altogether and roll back the previous changes.
Whatever...
isieo
Kami-Sama Desu~
Kami-Sama Desu~
Posts: 195
Joined: 04 Apr 2008, 09:24
Noob?: Yes
Location: 31th Dimension

Re: Stop misusing config.txt's block format

#12 Post by isieo »

i think we should change config.txt first then after the next release, knock off the code.
hakore
Super Moderators
Super Moderators
Posts: 200
Joined: 16 May 2008, 08:28
Noob?: No

Re: Stop misusing config.txt's block format

#13 Post by hakore »

Ok.

Reverted the default config.txt to the old format (consequently, removed deprecated config options and fixed misspelled entries). The teleportAuto block will no longer be supported after the next release (probably, at v.2.0.7).

Unless someone else would push for a better cosmetic revamping of config.txt, the inline options of config.txt will have to remain with the old format.
Whatever...
Cozzie
Spam Generator
Spam Generator
Posts: 499
Joined: 04 Apr 2008, 09:30
Noob?: No
Location: Melbourne, City of beer and awful sushis

Re: Stop misusing config.txt's block format

#14 Post by Cozzie »

Kissa2k wrote:For users there is no matter which teleport syntax is using in openkore
Usability. having a bunch of code with the same opening letters(ie: teleport_auto_xxx) reduces readability.
Make Openkore Awesome. Join the team.
sli
Perl Monk
Perl Monk
Posts: 810
Joined: 04 Apr 2008, 17:26
Noob?: No

Re: Stop misusing config.txt's block format

#15 Post by sli »

Cozzie wrote:
Kissa2k wrote:For users there is no matter which teleport syntax is using in openkore
Usability. having a bunch of code with the same opening letters(ie: teleport_auto_xxx) reduces readability.
Sure, but anyone with any learning ability isn't bothered by that. A block will just end up confusing the same people that are already confused even more so than they already are. (That was confusing.)
cs : ee : realist
Cozzie
Spam Generator
Spam Generator
Posts: 499
Joined: 04 Apr 2008, 09:30
Noob?: No
Location: Melbourne, City of beer and awful sushis

Re: Stop misusing config.txt's block format

#16 Post by Cozzie »

not really, it makes it consistent with how other settings are placed inside a block. Either way, every little thing helps in the long run, especially in configuring/maintaining/debugging.
Make Openkore Awesome. Join the team.
sli
Perl Monk
Perl Monk
Posts: 810
Joined: 04 Apr 2008, 17:26
Noob?: No

Re: Stop misusing config.txt's block format

#17 Post by sli »

Think about all the people who are gonna flood and forum/IRC when their old teleportAuto settings no longer work. Those are the people I'm talking about, the ones who don't understand curly braces.
cs : ee : realist
Cozzie
Spam Generator
Spam Generator
Posts: 499
Joined: 04 Apr 2008, 09:30
Noob?: No
Location: Melbourne, City of beer and awful sushis

Re: Stop misusing config.txt's block format

#18 Post by Cozzie »

hrmm.... is it a good idea to depreciate the old style? I'd say just do it, make a trigger in IRC and a BIG BANNER on top and link it to a faq page. It should be done.
Make Openkore Awesome. Join the team.
hakore
Super Moderators
Super Moderators
Posts: 200
Joined: 16 May 2008, 08:28
Noob?: No

Re: Stop misusing config.txt's block format

#19 Post by hakore »

Hmm... maybe we don't understand each other here.

With isieo's consent, the teleportAuto block will be knocked off. So there's no inline-option-to-block-format change for now. And while v.2.0.6 will carry on such hidden feature, it will not be documented so that it will not be used widely by users. The code will be entirely removed on the next version.

If you however want to push through with cosmetic changes in config.txt, drop the curly bracket option. I say it will not be done that way for the inline options.
Whatever...
Cozzie
Spam Generator
Spam Generator
Posts: 499
Joined: 04 Apr 2008, 09:30
Noob?: No
Location: Melbourne, City of beer and awful sushis

Re: Stop misusing config.txt's block format

#20 Post by Cozzie »

Yes I do get you and agree on not using the curly brackets style but why have v2.0.6 carry on this hidden feature? why not just remove the code all together or implement the new cosmetic change? It ties up loose ends which is what a stable release should do.

Managing the situation to prevent users swarming and spamming the forum/irc can be easily prevented or at least have the numbers massively reduced.
Make Openkore Awesome. Join the team.