WXSTart click OK 2.6.0.1 | crash when go in to gold area

[Technology]

Btw : when i go to gold room in my server the map of gold room is Pvp Room sandwich (pvp_n_8-1)
i Don't think so is a custom map

Yea, thats definetly not a custom map, but its not in the openkore fields pack either or atleast not by that name.
But maybe kore has an alternative name for that map.
Check out function Field::nameToBaseName, it does not have /^pvp_n_\d-1$/
That could be a problem when we create a new Field object with the parameter: name.
But then why isn't there any FileNotFoundException error trown?!

Tell us the exact steps on how we could reproduce this bug.
Do you hover the mouse over the minimap?

[alex1622]

Check out function Field::nameToBaseName, it does not have /^pvp_n_\d-1$/
That could be a problem when we create a new Field object with the parameter: name.
But then why isn't there any FileNotFoundException error trown?!

Tell us the exact steps on how we could reproduce this bug.
Do you hover the mouse over the minimap?

What do u want to mean with check out function field...... ?(sorry im verry idiot and noob )

i will tell u how i got this error

1 i start openkore
2-warp to prontera
3-talk to npc manual
3 respond npc manul
4-npc warp me to gold room
5- when i warped i can see names from monster from this gold room
and one or 2 second opekore got crash

If u need to prove this bug server info :

[Iko ro]
ip 216.245.211.37
port 6900
master_version 18
version 20
serverType 8_2
private 1
serverEncoding Western

[Click]

remember. if error start.exe, then it not wxstart problem.

[Technology]

What do u want to mean with check out function field...... ?(sorry im verry idiot and noob )

I meant that for the devs to read, i'm trying to provide possibly usefull information there.

when i use run start i didn't get any errors

Yea, it is most likely an openkore wx-interface bug.

While looking trough the .grf, i noticed that there is not even a .gnd, .gat, .rsw for pvp_n_8-1.
There are maps like job_hunter et. al... so we just need to find the right name for that map afaik.

[alex1622]

remember. if error start.exe, then it not wxstart problem.

i got this error from Wxstart >.<

Yea, it is most likely an openkore wx-interface bug.

While looking trough the .grf, i noticed that there is not even a .gnd, .gat, .rsw for pvp_n_8-1.
There are maps like job_hunter et. al... so we just need to find the right name for that map afaik.

so can i doo something for solve this or i have to wait from devps solve this ?

thnx by the way

[Technology]

Have some patience.
I couldn't find the map(s) in the sdata.grf but maybe they used to exist,
i'm not sure how the RO client handles them now, maybe trough aliasses.

btw, i think that this map (Map Name: PvP : Room Sandwich /^pvp_n_\d-1$/) is an alias for new_zone03.

EDIT: patch for more map aliasses (might need a better system to do this in the future)

Code: Select all

Index: Field.pm
===================================================================
--- Field.pm	(revision 6658)
+++ Field.pm	(working copy)
@@ -357,16 +357,29 @@
 		# For example, the newbie grounds (new_1-1, new_2-1, etc.) all look the same,
 		# even though they're different fields and may have different monsters.
 		# Take care of that.
+		
 		if ($name =~ /^new_\d-(\d)$/) {
 			$name = "new_zone0$1";
 		} elsif ($name =~ /^force_\d-(\d)$/) {
 			$name = "force_map$1";
+		} elsif ($name =~ /^pvp_n_\d-1$/) {
+			$name = "new_zone03";
 		} elsif ($name =~ /^pvp_n_\d-2$/) {
 			$name = "job_hunter";
 		} elsif ($name =~ /^pvp_n_\d-3$/) {
 			$name = "job_wizard";
+		} elsif ($name =~ /^pvp_y_\d-4$/) {
+			$name = "job_priest";
 		} elsif ($name =~ /^pvp_n_\d-5$/) {
 			$name = "job_knight";
+		} elsif ($name =~ /^pvp_y_\d-1$/) {
+			$name = "prontera";
+		} elsif ($name =~ /^pvp_y_\d-2$/) {
+			$name = "izlude";
+		} elsif ($name =~ /^pvp_y_\d-3$/) {
+			$name = "payon";
+		} elsif ($name =~ /^pvp_y_\d-4$/) {
+			$name = "alberta";
+		} elsif ($name =~ /^pvp_y_\d-5$/) {
+			$name = "morocc";
 		}
 		$baseName = "$name.fld";
 	}

(i'll commit this along with the Field.pm that supports .fld2, when .fld2 -> .dist (also .fld -> .dist actually) parsing in .xs is fixed)

[alex1622]

Have some patience.
I couldn't find the map(s) in the sdata.grf but maybe they used to exist,
i'm not sure how the RO client handles them now, maybe trough aliasses.

btw, i think that this map (Map Name: PvP : Room Sandwich /^pvp_n_\d-1$/) is an alias for new_zone03.

EDIT: patch for more map aliasses (might need a better system to do this in the future)

Code: Select all

Index: Field.pm
===================================================================
--- Field.pm	(revision 6658)
+++ Field.pm	(working copy)
@@ -357,16 +357,29 @@
 		# For example, the newbie grounds (new_1-1, new_2-1, etc.) all look the same,
 		# even though they're different fields and may have different monsters.
 		# Take care of that.
+		
 		if ($name =~ /^new_\d-(\d)$/) {
 			$name = "new_zone0$1";
 		} elsif ($name =~ /^force_\d-(\d)$/) {
 			$name = "force_map$1";
+		} elsif ($name =~ /^pvp_n_\d-1$/) {
+			$name = "new_zone03";
 		} elsif ($name =~ /^pvp_n_\d-2$/) {
 			$name = "job_hunter";
 		} elsif ($name =~ /^pvp_n_\d-3$/) {
 			$name = "job_wizard";
 		} elsif ($name =~ /^pvp_n_\d-5$/) {
 			$name = "job_knight";
+		} elsif ($name =~ /^pvp_y_\d-1$/) {
+			$name = "prontera";
+		} elsif ($name =~ /^pvp_y_\d-2$/) {
+			$name = "izlude";
+		} elsif ($name =~ /^pvp_y_\d-3$/) {
+			$name = "payon";
+		} elsif ($name =~ /^pvp_y_\d-4$/) {
+			$name = "alberta";
+		} elsif ($name =~ /^pvp_y_\d-5$/) {
+			$name = "morocc";
 		}
 		$baseName = "$name.fld";
 	}

(i'll commit this along with the Field.pm that supports .fld2, when .fld2 -> .dist (also .fld -> .dist actually) parsing in .xs is fixed)

Mmm im the same people who didn't understar that haha
how i can lear about this code ?
what kind of code it's ?


Editing :


Can some one help me ?

[iamanoob]

nice one... a big help.
@alex1622
this aliasing (maybe a term coz its the same) is for those maps
that have DIFFERENT map names but the SAME content... (same walkable water or walls)
it does help like reducing the size of the field folder
mine is 93.5MB

@Technology
is there a way for accessing this flds and dist files
when the fields folder is zipped
like kore needs newzone from fields.zip
instead of that huge 93.5MB in kore's directory
(or is it only mine that's UBER large??? o.O)

[Technology]

@iamanoob
kore already supports gzip compression, read more about it here

Kore field pack is 1.29 megs with gzip compression. Not to shabby.

The aliasing is also done by the client, therefore there are no .gat & .rsw files for each of these mapnames.
That this reduces the size of data is merely a side effect for us, tho was most likely gravity's intention in the first place.

I've discussed this with kLabMouse and in the future there will be a table file for map aliasing.
(unless there is a better idea)

Refactoring table files system
We could do some refactoring in the tables to improve maintainability and to support pservers with custom items.
Because, what we can copy straight from the client is less error-prone.

Where does these table's data come from btw? Its not documented anywhere, tho important to know.

There are different types of tables, namely those that contain data which is:
1) hardcoded in the client (directions.txt, headgears.txt, recvpackets.txt, map aliases, ...)
2) found inside the .grf or data folder (skillsdescriptions.txt, itemslots.txt, ...)
3) used by kore to translate an ID into a human readable name.(monsters.txt -> generated from received packets)
4) used by kore to determine: wether a map is a (city, field, dungeon), the type of a skill (area, spell, ...), ...
5) used by kore to store/obtain server specific (npc) information (npcs.txt, portals.txt, ...)
*) a combination of some the above (skills.txt, ...)

These are some idea's/questions specific to these table types:
1) can be extracted from the client like with recvpackets (packetlenghts)?
2) copy-paste (and don't touch it)
3)
4) we could use flags (possibly bitflags like .fld2) for skilltypes and map/monster properties etc.
5)
*) these tables could be splitted into one of the above types if found usefull (ex. skills.txt into 2 and 3)

openkore todo

[iamanoob]

could openkore just hook its data from the RO clients data folder or sdata.grf?? XD
like using the RO datas for openkore datas
and openkore datas would only contain algos
yup. disadvantage is that openkore NEEDS the client XD
but just an option if kore could use that data (o.O sneaky)


how to gzip a folder???
or gzip each file manually???!!!!