TRO Fix 2008-09-16 (Satan Morocc)

[singgih]

I try this in id RO but the kore cannot recognize player my pris didn't heal the master but for solo hunting it's well

[Dawg]

I followed the steps, this is what i got:

Code: Select all

Number found where operator expected at src/Network/Receive.pm line 5, near "rev
ision 6546"
        (Do you need to predeclare revision?)
Array found where operator expected at src/Network/Receive.pm line 9, at end of
line
        (Missing semicolon on previous line?)
Array found where operator expected at src/Network/Receive.pm line 9, near "24 "

        (Missing operator before  ?)
String found where operator expected at src/Network/Receive.pm line 11, near "@@


      '02AD'"
        (Missing operator before '02AD'?)
syntax error at src/Network/Receive.pm line 3, near "===="
Unmatched right curly bracket at src/Network/Receive.pm line 32, at end of line
Compilation failed in require at openkore.pl line 58.
BEGIN failed--compilation aborted at openkore.pl line 58.

Press ENTER to exit.

[Dawg]

my bot worked, but i got dis from 1 of my accounts. the others didnt got this

Unknown packet - 016C

what seems to be the prob w/ this account?

[littlewens]

Thank you UltimaWeapon. =)

a tiny place could be modified at the first post, here:

my $psize = ($switch eq "0123") ? 10 : 18;

+ if ($switch eq '0123') {
+ $psize = 10;
+ } elsif ($switch eq '02E9') {
+ $psize = 22;
+ } else {
+ $psize = 18;
+ }
+

should be (add a minus symbol at the first line):

- my $psize = ($switch eq "0123") ? 10 : 18;

+ if ($switch eq '0123') {
+ $psize = 10;
+ } elsif ($switch eq '02E9') {
+ $psize = 22;
+ } else {
+ $psize = 18;
+ }
+

[h4rry84]

my bot worked, but i got dis from 1 of my accounts. the others didnt got this

Unknown packet - 016C

what seems to be the prob w/ this account?

that's Guild Packet Info. not a problem as that's a simple fix

the main problem is, the actor player. it didn't recognized well. the name,distance is screwed up

[h4rry84]

@littlewens
if you do that, it would cause an error because no init for psize var.

it's better to change it into

Code: Select all

my $psize;

[littlewens]

Hello h4rry84:

If so, all the "my $psize = ..." should be removed and then add the line "my $psize;" at the first post. ^^"

I'm playing in twRO Test Server, and here are my processing:

1. manually modified the /src/Network/Receive.pm, /src/Network/Send/ServerType0.pm according to the first post.

2. manually added the src\Network\Send\ServerType21.pm, src\Network\Receive\ServerType21.pm according to the first post.

3. disabled the sub account_server_info in src\Network\Receive\ServerType21.pm according to the 10th post.

4. Update our recvpackets.txt by using JCV's RO Tools 1.0.3 and modified the

Code: Select all

0165 30
0166 0
0166 0
0167 3
0167 3
0168 14
0168 14
0169 3
0169 3
016A 30
016A 30
016B 10
016B 43
016B 10
016B 43

to: (I don't know why this would happened, maybe RO Tools' bug?)

Code: Select all

0165 30
0166 0
0167 3
0168 14
0169 3
016A 30
016B 10
016C 43

5. At servers.txt, set serverType to 21

Here are the result:

1. When typing command "ml", "nl", "cart", "s", "st", all displayed correctly.

2. [strike]When typing command "pl", some player info displayed correctly, some didn't.[/strike] Fixed. Thanks H4rry84 and heero. ^_^

[strike]Player 0, 1, 2 couln't be detected the name. Player 0, 1 had the wrong Lv, Dist and Coord. Only player 3 showed the correct info.[/strike]

3. There is a little abnormal thing when attacking monsters:

it will sometimes display the "0 + 2816" damage to the bot, but actually the mob didn't hurt the bot.

4. When using XKore 1 mode, it shows the unknown packet AE2D then openkore crashed:


The above are all my observation about this update. =)

[h4rry84]

Just been working on it with heero. and the result is quite Good.

and about the my $psize; it respond according to your post. coz the upper part doesn't change the type init var. some of the diff file come with typo or minor something

about player Info, open receive.pm replace with this :

Code: Select all

'02EE' => ['actor_display', 'a4 v3 V1 v10 a4 a4 V1 C2 a3 x1 v v2', [qw(ID walk_speed param1 param2 param3 type hair_style weapon shield lowhead tophead midhead hair_color clothes_color head_dir guildID guildEmblem visual_effects stance sex coords act lv unknown)]],

[h4rry84]

okay, some modification has been made and it's working good unless for xKore :p need further test. Heero said it will be commited soon after the xKore work

[UltimaWeapon]

@littlewens
Thanks for fixed it.

I think unknown argument in 'actor_display' and 02EB 'map_loaded' it should be Battle Ground data. Because it have the same size (WORD) and it is one of actor data.

02EB in my first post it is incorrect. It should be

Code: Select all

'02EB' => ['map_loaded', 'V1 a3 x2 v1', [qw(syncMapSync coords unknown)]],