webMonitor v2 - by BonScott

[BonScott]

Works for me with using --control, --plugins and --interface options. webMonitor doesn't load at all or just doesn't initialize webserver? Do other plugins load fine in the same openkore instance?

All the polugins load fine, including webMonitor, but the webServer dont. The messagem "web server started in localhost:XXXX" dont show in end of plugin loading.

[EternalHarvest]

Now it should tell why exactly it fails (when starting servers).

[BonScott]

which packages should I install for proper working the map (wx support)?

I have:

Code: Select all

Protocol::WebSocket
JSON-Any
JSON-PP
Wx

[EternalHarvest]

Just "Wx" should be enough for map images.

Added "webMapURL" option so you can just use whatever site with map images you want, for example "http://www.ragdata.com/images/maps/%s.jpg" to use what your version previously used.

Maybe we should use "web_" prefix for options, like many features do, since there's probably more other options coming?

[BonScott]

One more attempt:

- Fresh openkore (svn)
- Fresh plugin (webMonitor@svn)
- no additional plugins

packs installed in perl:

Code: Select all

Protocol::WebSocket
JSON-Any
JSON-PP
Wx

The server star, open the page in browser BUT, crash on load map image, a windows window (lol) show the following error:

Code: Select all

---------------------------
perl.exe - Não foi possível localizar componente
---------------------------
Este aplicativo não pôde ser iniciado porque não foi encontrado wxmsw28u_core_vc_custom.dll. A reinstalação do aplicativo pode corrigir o problema. 
---------------------------
OK   
---------------------------

Solution, use webMapURL in config =/

[Cholik]

I was searching for a webinterface for openkore and well I found this. Since it's the only one being developed atm.
But to be honest i have to say that i'm a bit disappointed with it. I'm pretty good with web development but i suck in perl, and it's kinda sick for me to write code in perl (since i'm used to other programming languages which do not confuse me ).



I mean its not that hard to improve that interface, I even got the current char position (displayed by a blue dot) working on the minimap in about 10 minutes (which is pretty easy using canvas in javascript) but since the plugins structure and how the websocket is used is pretty strange i had to write a lot of dirty code. Perhabs i'll be able to read more into perl and can help out more.

[EternalHarvest]

I mean its not that hard to improve that interface

Sure. There are a lot of very easy possible improvements. Displaying your position should be trivial because I've actually prepared things to do that next.

but since the plugins structure and how the websocket is used is pretty strange i had to write a lot of dirty code. Perhabs i'll be able to read more into perl and can help out more.

When I was trying to improve all of that, I've found that just about everything in this plugin was, in my opinion, made wrong. Poor "templating" module, not great perl code structure, weird html structure, html parts in perl, bloated and not exceptionally good css library, a lot of bugs, security issues etc. Well, for websocket part you can blame me if there's something totally wrong, but it's still "in development" as you have noticed.

[Cholik]

I mean its not that hard to improve that interface

Sure. There are a lot of very easy possible improvements. Displaying your position should be trivial because I've actually prepared things to do that next.

but since the plugins structure and how the websocket is used is pretty strange i had to write a lot of dirty code. Perhabs i'll be able to read more into perl and can help out more.

When I was trying to improve all of that, I've found that just about everything in this plugin was, in my opinion, made wrong. Poor "templating" module, not great perl code structure, weird html structure, html parts in perl, bloated and not exceptionally good css library, a lot of bugs, security issues etc. Well, for websocket part you can blame me if there's something totally wrong, but it's still "in development" as you have noticed.

Nope I dont want to blame anyone at all, I like the idea behind that plugin and I'm pretty jealous... I'm not familiar with Perl to produce something like that.

I agree to what you say regarding the plugin mechanics and structure, I hope you guys can find some time to clean that up as I'd like to use an improved version of this plugin. And I think the basic part of the Websocket stuff is okay, I just don't like the idea of sending html data using websockets. Of course providing files etc is okay but I would rely a bit more on the client if its about processing data.


Hehe I was just playing around a bit, like implementing the char position stuff, tried to implement the monsters on sight (monstersList) and failed LOL Perl doesn't like me.

PS: If you'll ever be thinking about rewriting the interface, using something a bit more dynamic... you should check out DHTMLX or ExtJS.

[EternalHarvest]

And I think the basic part of the Websocket stuff is okay, I just don't like the idea of sending html data using websockets.

Doesn't it just send various values and console text? There is no html there.

[Cholik]

And I think the basic part of the Websocket stuff is okay, I just don't like the idea of sending html data using websockets.

Doesn't it just send various values and console text? There is no html there.

Maybe I got an outdated version, but I thought i saw some html lines being sent, nevermind.

I hope you're also planning on using the websocket to send data from client -> server, cause atm the interface is still using normal submits using get/post parameters, or am I wrong?