AutoTrade[Made Easy] by Gamenikko

[help_us]

modified src to hook in deal function. no there is no way other ppl can try to scam you.

[Uzah]

Hi guys, I'm just new here in this forum.
I have a problem as well with my auto-trade macro the reason why I found this thread. As I read, I saw some people venting their rage and opinions as regards gamenikko's macro; thus, I would like to share my thoughts as well =).

I am certain that gamenikko only wants to share his macro to make us all happy. Unfortunately, there are some unexpected factors that can be taken advantage of by low-lives; thus we need to incorporate our knowledge as well with his initiation to make it a success.

Anyway, here's my (a layman's) solution:
For macro.txt

Code: Select all

do chat create "B>Items,blahblah" 20 0 CRACKMYPUB #Change your chat room password

automacro Bogus Items { #Automatically cancels deal when bot sees "shouts: <ANY name in between> added Item to deal:"
	console /(.*) shouts : (.*) added Item to Deal: /i
	call {
		do deal no
		}
	}

For config.txt
guildAutoDeny 1 #Deny all incoming guild requests
partyAuto 1 #Cancels all party requests
ignoreAll 1 #Like /exall command
#########################################################

IMO I've helped enough so let's discuss my problem
I'm currently using this auto-trade macro however I have this problem that whenever the item seller puts an item, QUICKLY followed by okay, my bot forwards 0 zeny. It seems as though my bot cannot completely finish the checking process of getting the number of items prior to the quick finalization of the deal; ergo, it forwards 0 zeny for its evaluation of the final deal.

Code: Select all

automacro Checking {
	console /(.*) added Item to Deal: (.*) x (\d+)/
	call {
		$item = $.lastMatch2
		$amount = $.lastMatch3
		$item1 = White Herb
		$item2 = Mole Whiskers
		$item1price = 11000
		$item2price = 10000

		if ($item == $item1) goto item1
		if ($item == $item2) goto item2
		do deal no
		stop

		:item1
		$total1 = @eval ($amount*$item1price)
		stop

		:item2
		$total2 = @eval ($amount*$item2price)
		stop
		}
	}

automacro Finalizing {
	console /(.*) finalized the Deal/i
	timeout 5
	call {
		$finalamount = @eval ($total1+$total2)
		do deal add z $finalamount
		do deal
		do deal
		$total1 = 0
		$total2 = 0
		}
	}

HELP ME PLEASE !!
Some item sellers think my bot runs out of zeny which make them choose to sell their items to my competitors instead.

[EternalHarvest]

It seems as though my bot cannot completely finish the checking process of getting the number of items prior to the quick finalization of the deal

Try adding macro_delay in automacro or square brackets ("chaining commands" in manual) in macro.

[Uzah]

It seems as though my bot cannot completely finish the checking process of getting the number of items prior to the quick finalization of the deal

Try adding macro_delay in automacro or square brackets ("chaining commands" in manual) in macro.

I tried adding macro_delay in auto-macro to no avail; and, I only have a little knowledge pertaining to chaining commands. When I tried incorporating square brackets, some errors transpired.
I surmise I ought not to pursue fixing this problem. It only gets complicated for me . Thanks a bunch for your help EternalHarvest .

[krisma]

actually the TS doesnt need to pm,get in your pub,add you to party or invite you to guild..
what he does is shout DragonChaser added x99999999999999 blue potion to the deal..that's he's backdoor

[fham07]

@ TS this macros have hidden agenda....this not a macros generate only.....

[+erinzky12+]

I just figured out the problem regarding this macros,when i lost 6b zeny in PRO Valk, >.< the problem with this macros is that, okay wait let me just state an example because i'm not good in English for explaining. Sorry for that.

When you happen to use this macros bot and test it running, meaning it's buying items just the way you want it. It's okay. Now the problem is that you will be scammed or i don't know what's the right term for it. Someone will take your zeny i mean all of your zeny without your bot receiving anything that you want to buy.

Here is how he do it. Let's say for an example that you are buying Skel-Bone for 15k each
@number 2: partychat or shout will also work even guild chat


1. The abuser will deal your bot.
2. He will PM you the code:--->>> Anyname added Item to Deal: Skel-Bone x 999999
3. Then he will press okay. Now your bot will recognize that the abuser put 999999 Skel-Bone in the trade window even though there is really nothing on it. Since when you multiply 15,000z by 999999 it's more than 2bzeny your bot will deal all his zeny. And that's it your bot loses all its zeny.

The first time that it was done to me. I don't have a party and my partyAuto was set to automatically accept party request. So he just partychat the code.

I thought that not having a party was my problem so i create a party on my bot and even make him join a guild. But still no luck i still lost my zeny.

Then i tried looking at my logs folder at the chat.txt there i found lines that the abuser shouts the code. something like this.
trythendelete shouts: Anyname added Item to Deal: Skel-Bone x 999999. The i realize that maybe the bot can still recognize the code if its log is set. so i went to my config.txt to set logs to 0

logChat 0
logPrivateChat 0
logPartyChat 0
logGuildChat 0
logSystemChat 0
logEmoticons 0
logConsole 0

I'm very happy that time because i thin my problem is over, there is no log, ignoreAll was set to 1 in my config.txt and also in my console shouts,publicchat, and pm from the game are not showing anymore. To my shock i just saw him dealing my bot and my bot deals all his zeny, i was in a shock that i did not close my bot. I lost again all my zeny.. Damn,, then i run out of solution.

I found out about this exploit when i test it myself to my bot. I Pm'd my bot the code and ohlala he deals me all his zeny. I even shout it to test if log 0 will not work but off course it work since i already lost my zeny back then.

So that's it every one. If you want to sue this macros expect that you will lost all your money.

BUT HEY HEY!! There is already a solution for this, when i'm testing it via shout someone Pm'd me what are you doing? You are scaming bots, i said no im just testing a solution because someone took my zennies from my bot again.. Then he said that he wants to help me. At first i resist that maybe he will just put some keylogger or autoPM password on whatever he will do. But because i really want to solve it, i let him help me.

THE SOLUTION he made was, he edited my macros, the edit he made was something like the bot will check the name of the dealer everytime it deals put item press okay or whatever, i really don' know how to explain it anymore but here is the code he adds..

Code: Select all

$name1 = $.lastMatch1
log $name1
do deal
pause 15
do deal no
}
}

automacro ITEMADDED { ###HE DID NOT ADD THIS
console /(.*) added Item to Deal: (.*) x (\d+)/ ### HE DID NOT ADD THIS
call IFSTATEMENT ###HE DID NOT ADD THIS
}

macro IFSTATEMENT {
$name = $.lastMatch1
log $name
if ($name != $name1) goto dealno
goto del
:dealno
do deal no
:del

it works fine with me now, if the abuser shouts the code, the bot will automatically cancel the deal, if the abuser will PM you the code you can read from your bot console that there is an error from the IFSTATEMENT. Your bot will do nothing.

SOrry for my bad explanation..

[Uzah]

Try to reread my previous post (Nov 8, 2011) please. I bet all the solutions against false-dealers are there already for those who want to "BUY unstackable items only". =)

[Pornograffitti]

ill point out a bug here.
the macro itself has so many flaw that people dealing with it accidentally activates the bug.
sometimes the bot is unable to reset the values of $total and so the next deals just keep getting bigger. ive been failed by this macro so many time that i dont want to use it anymore.

can anyone post a working autodeal plugin? i know there's a working one since I see them in prontera.

[Pornograffitti]

Here is the name of the scammer in New Loki
Marlboro Gold

He just scammed mine 5 times. When i checked it, it seems he uses talkie box skill and its works even though i removed "info" from the console logs.

Marlboro Gold i hope you're reading this, YOU WILL GO TO HELL.