r8367 (ErrorHandler changes)

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

Message
Author
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

r8367 (ErrorHandler changes)

#1 Post by EternalHarvest »

http://openkore.svn.sourceforge.net/vie ... ision=8367

Code: Select all

+ use Translation;
Translation module itself may fail or not be ready there, code you removed was handling this situation.

Code: Select all

+ $net->serverDisconnect() if ($net);
May throw further errors and interfere with error reporting.
Also: "This function is used internally by $net->checkConnection() and should not be used directly."

Code: Select all

- exit 9;
What's the reason for changing exit status?
All of this and unrelated TaskManager change in one commit
What about more atomic commits?

Kaspy
Halfway to Eternity
Halfway to Eternity
Posts: 398
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

Re: r8367 (ErrorHandler changes)

#2 Post by Kaspy »

EternalHarvest wrote:

Code: Select all

+ use Translation;
Translation module itself may fail or not be ready there, code you removed was handling this situation.
Right, I will remove.
EternalHarvest wrote:

Code: Select all

+ $net->serverDisconnect() if ($net);
May throw further errors and interfere with error reporting.
Also: "This function is used internally by $net->checkConnection() and should not be used directly."
But the error report has not been generated? How will compremete it?

Well, in normal situations, it is not good that the BOT stay connected without this working. Think less periogoso disconnects it than keep it ON.
Image

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: r8367 (ErrorHandler changes)

#3 Post by EternalHarvest »

KeplerBR wrote:Right, I will remove.
Just revert this part, it worked fine right?
But the error report has not been generated? How will compremete it?

Well, in normal situations, it is not good that the BOT stay connected without this working. Think less periogoso disconnects it than keep it ON.
Maybe wrapping ->serverDisconnect() with eval {} will help.

Post Reply