r8367 (ErrorHandler changes)

[EternalHarvest]

http://openkore.svn.sourceforge.net/vie ... ision=8367

Code: Select all

+ use Translation;

Translation module itself may fail or not be ready there, code you removed was handling this situation.

Code: Select all

+ $net->serverDisconnect() if ($net);

May throw further errors and interfere with error reporting.
Also: "This function is used internally by $net->checkConnection() and should not be used directly."

Code: Select all

- exit 9;

What's the reason for changing exit status?

All of this and unrelated TaskManager change in one commit

What about more atomic commits?

[Kaspy]

Code: Select all

+ use Translation;

Translation module itself may fail or not be ready there, code you removed was handling this situation.

Right, I will remove.

Code: Select all

+ $net->serverDisconnect() if ($net);

May throw further errors and interfere with error reporting.
Also: "This function is used internally by $net->checkConnection() and should not be used directly."

But the error report has not been generated? How will compremete it?

Well, in normal situations, it is not good that the BOT stay connected without this working. Think less periogoso disconnects it than keep it ON.

[EternalHarvest]

Right, I will remove.

Just revert this part, it worked fine right?

But the error report has not been generated? How will compremete it?

Well, in normal situations, it is not good that the BOT stay connected without this working. Think less periogoso disconnects it than keep it ON.

Maybe wrapping ->serverDisconnect() with eval {} will help.