"Old" r8882 and earlier inventory looks as follows:
Code: Select all
-----------Inventory-----------
-- Equipment (Equipped) --
6 Novice Adventurer's Suit [Pupa] [1] -- Armor (16)
7 Clip [1] -- Right Accessory (8)
9 +7 Muffler [1] -- Cape (4)
10 +4 Hunter Bow -- Two-Handed Weapon (34)
-- Equipment (Not Equipped) --
5 Steel Arrow (Arrow) x 50
-- Non-Usable --
2 Eden Group Mark x 1
-- Usable --
0 Novice Fly Wing x 42
1 Novice Butterfly Wing x 24
3 Yellow Butterfly Wing x 1
-------------------------------
Code: Select all
------------------- Inventory --------------------
-- Usable --
0 Novice Fly Wing x 42
1 Novice Butterfly Wing x 24
3 Yellow Butterfly Wing x 1
-- Equipment (Not Equipped) --
5 Steel Arrow (Arrow) x 50
-- Non-Usable --
2 Eden Group Mark x 1
-- Equipment (Equipped) --
6 Novice Adventurer's Suit [Pupa] [1] -- Armor (16)
7 Clip [1] -- Right Accessory (8)
9 +7 Muffler [1] -- Cape (4)
10 +4 Hunter Bow -- Two-Handed Weapon (34)
--------------------------------------------------
Was this changeset tested at all before being committed?
<snotty opinion somewhat grounded in experience>
There's a reason why we write commit messages, and limit the commit to what we say has been changed.
When an author commits a change -- one change, that is -- it reduces the complexity to test that one change by several orders of magnitude when the one feature changed is isolated, instead of leaving the change to be fixed.
When dozens (hundreds?) of changes are made, and combined together in one massive update, this makes bug hunting post-commit much more involved, and pre-commit, it leaves the coder/tester many more opportunities to miss checking and testing for unintended changes their massive update can cause.
IMO, this commit should've been at least 4, given the four unrelated notes in the commit message.
However, the translation updates to Commands.pm should have been several dozen commits all by themselves.
</snotty opinion somewhat grounded in experience>