@EternalHarvest
I think you're absolutely right, but I would like to give my opinion on this....
I don't know if Openkore aim to replicate official clients' behaviour. But if this is true, a lot of clients, specially those used in official servers use some restrictions in order to prevent chat abuse, some of them:
- * players can't send the same message 3 times in a row. (client side)
* if a player sends a lot of messages in a short time, he'll automatically get his chat blocked for some time (detection on client side?)
* manner.txt filter (client side)
OpenKore won't respect any of those restrictions and if the user don't pay close attention when using chat/pm in OpenKore he can get banned pretty easily. Today it seems like there's not much effort in banning players for this, but back when bRO GM team was much more rigid, I was banned for using a word that was inside manner.txt.
Then there's community approval. I don't play RO anymore so for me it's easier to give an opinion based more on a "kore user" than "RO botter". But even botters are more satisfied when they see less SPAM in-game. Probably the only ones that will get angry at this are zenny sellers and private server owners (they used to advertise their private servers inside official servers using openkore).
EternalHarvest wrote:If those "spam" checks disturb normal PM usage (including automated - and that's where they probably will), they shouldn't be implemented at all.
Yes, everything related to these anti-spam measures were kept as much hidden as possible, and that was probably very wrong. However, the actual code won't affect the regular user unless he needs to send a lot of messages to a lot of users in a short period of time.
In my opinion, spam control code should be kept in OpenKore while making it easier to "understand". But if it needs to be removed that's fine for me too.