Localized tables autoload

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Localized tables autoload

#1 Post by EternalHarvest »

Why they aren't just added to official server entries in servers.txt, instead of being tied to ST? That way they would be more configurable and kRO ones will not be used with kRO ST (which is used for many private servers) by default.
Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: Localized tables autoload

#2 Post by Technology »

thats fine with me
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!
User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: Localized tables autoload

#3 Post by kLabMouse »

Good Suggestion.
But what to use by default??
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Localized tables autoload

#4 Post by EternalHarvest »

Current sources of table dirs:
1. --tables list OR default "tables" is not specified
2. all table dirs get a copy with named ST suffix (messing with any configuration that uses kRO ST or has suitable dirs in list specified with --tables)
3. addTableFolders from servers.txt (no way to unset these with --tables)

My opinion:
* when there is --tables, do not add anything from ST/servers.txt (maybe add some "base tables" option for redefining only one dir and getting everything)
* implement [2] with [3] for official servers' entries in servers.txt
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Localized tables autoload

#5 Post by EternalHarvest »

Why there is no monsters, npcs in trunk tables?
Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: Localized tables autoload

#6 Post by Technology »

EternalHarvest wrote:Why there is no monsters, npcs in trunk tables?
Because these files are different for different servers.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Localized tables autoload

#7 Post by EternalHarvest »

So there isn't any "default" tablepack anymore?
There is no skillnametable too, but statusnametable is here, should it be removed?
Technology
Super Moderators
Super Moderators
Posts: 801
Joined: 06 May 2008, 12:47
Noob?: No

Re: Localized tables autoload

#8 Post by Technology »

EternalHarvest wrote:So there isn't any "default" tablepack anymore?
Nope, as we want to encourage people to update kore's monsters.txt, npcs.txt and etc. for their specific official server.
Making them use the right tables is the first step in that process.
Also, i think we should keep the server specific tables separated from the non-server specific ones.
EternalHarvest wrote:There is no skillnametable too, but statusnametable is here, should it be removed?
statusnametable is also server specific. So yea, it should be moved to the folders that contain the server specific files.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...

Mount Doom awaits us, fellowship of OpenKore!
User avatar
kLabMouse
Administrator
Administrator
Posts: 1301
Joined: 24 Apr 2008, 12:02

Re: Localized tables autoload

#9 Post by kLabMouse »

About Server and Non Server specific tables.

There is One big problem in Current SVN.
the Private Server support.


Also I suggest:
1) Disable Server Specific Auto loading of tables IF there is option to load custom tables in servers.txt
2) Disable Server Specific Auto loading of tables IF more then one folder set by cmd option "--tables"
3) Enable Server Specific Auto loading only if above rules return False.
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: Localized tables autoload

#10 Post by EternalHarvest »

We need to sort out issues with tables directories and make the stable branch already.