What mean is the statement in funcion.pl ??

[sofax222]

I just try to make r7998 openkore could run with XKore 2 mode on twRO !
When I traced the code lines, I got a problem in the function.pl file.
As following segment code lines:

Code: Select all

...................
sub mainLoop_initialized {
	Benchmark::begin("mainLoop_part1") if DEBUG;

	# Handle connection states
	$net->checkConnection();

	# Receive and handle data from the RO server
	my $data = $net->serverRecv;
	if (defined($data) && length($data) > 0) {
		Benchmark::begin("parseMsg") if DEBUG;

		$incomingMessages->add($data);
		$net->clientSend($_) for $packetParser->process(
			$incomingMessages, $packetParser
		);
		$net->clientFlush() if (UNIVERSAL::isa($net, 'Network::XKoreProxy'));
		Benchmark::end("parseMsg") if DEBUG;
	}
.......................

In the mainLoop_initialized function of the function.pl file.
What mean is the statement of following ?

Code: Select all

		$net->clientSend($_) for $packetParser->process(
			$incomingMessages, $packetParser
		);

[EternalHarvest]

# Receive and handle data from the RO server

Code: Select all

		$net->clientSend($_) for $packetParser->process(
			$incomingMessages, $packetParser
		);

Process (parse and call handlers) all received packets from the server ($incomingMessages) using packet handlers in $packetParser (usually, an instance of Network::Receive). Pass each packet to clientSend which forwards packets to XKore client if there is any.

[sofax222]

Process (parse and call handlers) all received packets from the server ($incomingMessages) using packet handlers in $packetParser (usually, an instance of Network::Receive). Pass each packet to clientSend which forwards packets to XKore client if there is any.

So, the forwarding packects to XKore client is after the handlding packets with Network::Receive, isn't ?
But in r7762 (old one), the forwarding packects to XKore client is prior to the handlding packets with Network::Receive !

[EternalHarvest]

In r7762, parseIncomingMessage handles packets with Network::Receive and sends them to the client with clientSend.

[sofax222]

In r7762, parseIncomingMessage handles packets with Network::Receive and sends them to the client with clientSend.

Yes, I know it.
I means:
In r7762, the clientSend is before Network::Receive.
But in r7998, the clientSend is after Network::Receive.
Because, the $net->getState() changes with throungh portal,
it make some packets could not be sent to XKore 2 client.
PS: sending the packet to XKore 2 client only for $net->getState() == Network::IN_GAME