shop_LockOnly breaks default behaviour

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

shop_LockOnly breaks default behaviour

#1 Post by EternalHarvest »

That's an important default where you won't open (with shopAuto_open only, opening shops in general wasn't restricted) shop in a wrong place.
(Adding shop_LockOnly 1 in distributed config won't resolve that.)

Also poorly named option for many reasons.

http://openkore.svn.sourceforge.net/vie ... threv=8118

Why such option is need at all? What's the situation where you want to open your shop automatically (not with console command etc), and at the same time to keep lockMap configured to another map? Does it work at all, wouldn't navigating to lockMap have priority over shopAuto_open anyway?
Kaspy
Halfway to Eternity
Halfway to Eternity
Posts: 398
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

Re: shop_LockOnly breaks default behaviour

#2 Post by Kaspy »

[EN]
I regret for having created it and do not know why I did it... I think it was not very well head.

It also has other functions config.txt that would not be very good being there, as removeActorWithDistance.

[PT-BR]
Eu me arrependo por ter criado isso e não sei porque fiz isso... Acho que não estava muito bem da cabeça.

Também tem outras funções do config.txt que não seria muito bom estarem lá, como o removeActorWithDistance.
Image
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: shop_LockOnly breaks default behaviour

#3 Post by EternalHarvest »

KeplerBR wrote:I regret for having created it and do not know why I did it... I think it was not very well head.
If you think that it's not needed, we can just revert these changes.
It also has other functions config.txt that would not be very good being there, as removeActorWithDistance.
This one doesn't break existing behaviour by default, doesn't do anything by default, disabled in distribution and wiki explains what it was intended for. There are a lot of options like that which just do nothing by default.

Currently, it may be less useful for new servers (as many other options are) and/or overshadowed by clientSight (but not totally useless if you're trying to reduce CPU and memory usage by all means). If anything, it should be investigated further / added to bug reports / explained in wiki.

It could have been a plugin instead, but you can say that for many other features as well.
catcity
Noob
Noob
Posts: 18
Joined: 20 Oct 2012, 14:31
Noob?: No

Re: shop_LockOnly breaks default behaviour

#4 Post by catcity »

I actually have a half finished plugin where this config option might be applicable.

The concept of the plugin is that in between vending the merchant would carry out other automated tasks that would require him to move out of the lockmap. At times it might be necessary for the merchant, while not at his lockmap, to wait for some other event and in that downtime I don't want him opening up a shop wherever he is.

This could be handled within the plugin though. Not as a generic config option.
There's two types of people in this world, kid: Those who can, and those who can't; and cats...

[Plugin] Automatic Map Changer
Kaspy
Halfway to Eternity
Halfway to Eternity
Posts: 398
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

Re: shop_LockOnly breaks default behaviour

#5 Post by Kaspy »

Image
alicia45
Noob
Noob
Posts: 1
Joined: 14 Dec 2012, 08:16
Noob?: No

Re: shop_LockOnly breaks default behaviour

#6 Post by alicia45 »

catcity wrote:I actually have a half finished plugin where this config option might be applicable.

The concept of the plugin is that in between vending the merchant would carry out other automated tasks that would require him to move out of the lockmap. At times it might be necessary for the merchant, while not at his lockmap, to wait for some other event and in that downtime I don't want him opening up a shop wherever he is.

This could be handled within the plugin though. Not as a generic config option.


Same issue was with me, I have handled this within the Plugin though, but no result.. Please help me.
Kaspy
Halfway to Eternity
Halfway to Eternity
Posts: 398
Joined: 08 Jun 2012, 15:42
Noob?: No
Location: Brazil

Re: shop_LockOnly breaks default behaviour

#7 Post by Kaspy »

alicia45 wrote:
catcity wrote:I actually have a half finished plugin where this config option might be applicable.

The concept of the plugin is that in between vending the merchant would carry out other automated tasks that would require him to move out of the lockmap. At times it might be necessary for the merchant, while not at his lockmap, to wait for some other event and in that downtime I don't want him opening up a shop wherever he is.

This could be handled within the plugin though. Not as a generic config option.


Same issue was with me, I have handled this within the Plugin though, but no result.. Please help me.
I did not ... The function shop_LockOnly has been removed. This updated with OpenKore?
Image