The function, "visualDump" in Misc.pm

Wrote new code? Fixed a bug? Want to discuss technical stuff? Feel free to post it here.

Moderator: Moderators

sofax222
Developers
Developers
Posts: 214
Joined: 24 Nov 2010, 03:08
Noob?: Yes

The function, "visualDump" in Misc.pm

#1 Post by sofax222 »

I set "debugPacket_ro_sent 2" and "debugPacket_sent 2" in config.txt file.
And, run the openkore in without/with XKore 1 mode.

The following are the result from calling Misc::visualDump.
Without XKore 1 mode
================================================
>> Sent packet: 0064 [Account Server Login] [56 bytes]
0> 64 00 C3 93 00 00 00 30 30 30 30 30 30 30 30 00 d......00000000.
16> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30 ...............0
32> 30 30 30 30 30 30 30 00 00 00 00 00 00 00 00 00 000000.........
48> 00 00 00 00 00 00 00 05 ........
================================================

With XKore 1 mode
================================================
<< Sent by RO client: 0064 - Account Server Login [55 bytes]
0> 64 00 D3 00 00 00 30 30 30 30 30 30 30 30 00 00 d.....00000000..
16> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30 30 ..............00
32> 30 30 30 30 30 30 00 00 00 00 00 00 00 00 00 00 000000..........
48> 00 00 00 00 00 00 05 .......
================================================


And then, I remark the line "use bytes;" in visualDump function.
The following are the result from calling Misc::visualDump.
Without XKore 1 mode
================================================
>> Sent packet: 0064 [Account Server Login] [55 bytes]
0> 64 00 D3 00 00 00 30 30 30 30 30 30 30 30 00 00 d.....00000000..
16> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 30 30 ..............00
32> 30 30 30 30 30 30 00 00 00 00 00 00 00 00 00 00 000000..........
48> 00 00 00 00 00 00 05 .......
================================================

Why ths same message packet but different dump result ?
EternalHarvest
Developers
Developers
Posts: 1798
Joined: 05 Dec 2008, 05:42
Noob?: Yes

Re: The function, "visualDump" in Misc.pm

#2 Post by EternalHarvest »

Confirmed and committed visualDump changes.

Somebody should examine all "use bytes" uses (there are many), understand what they used for, add corresponding unit tests, and rewrite things without using bytes.