This place is for Closed bug reports only. NOT for asking help!
Moderators: Moderators , Developers
Technology
Super Moderators
Posts: 801 Joined: 06 May 2008, 12:47
Noob?: No
#1
Post
by Technology » 17 May 2010, 20:34
Which means we cannot use the following notation for these skills:
Which we currently do.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
kLabMouse
Administrator
Posts: 1301 Joined: 24 Apr 2008, 12:02
#2
Post
by kLabMouse » 18 May 2010, 14:59
MM. let's filter all Skill names for "(" + ")" and replace to "[" + "]"
So Skill names will not make our system crash.
Technology
Super Moderators
Posts: 801 Joined: 06 May 2008, 12:47
Noob?: No
#3
Post
by Technology » 18 May 2010, 15:14
kLabMouse wrote: MM. let's filter all Skill names for "(" + ")" and replace to "[" + "]"
So Skill names will not make our system crash.
i suggest we adapt our system, i for one want to be able to "drag and drop" (as a figure of speech) in skillnametable.txt from the .grf
Why do we need this notation anyways?
btw, i think the same problem applies to statuses?
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
kLabMouse
Administrator
Posts: 1301 Joined: 24 Apr 2008, 12:02
#4
Post
by kLabMouse » 18 May 2010, 15:36
Yes. the same.
As for me. Changing () -> [] isn't bad at all.
but.. most users use Skill name, or HANDLE. but not two of them in the same time.
EternalHarvest
Developers
Posts: 1798 Joined: 05 Dec 2008, 05:42
Noob?: Yes
#5
Post
by EternalHarvest » 18 May 2010, 15:42
"skillname" in this notation is just a random text (now), and this random text can be put in comments if needed instead.
Technology
Super Moderators
Posts: 801 Joined: 06 May 2008, 12:47
Noob?: No
#6
Post
by Technology » 18 May 2010, 16:48
EternalHarvest wrote: "skillname" in this notation is just a random text (now), and this random text can be put in comments if needed instead.
yes, i think the same about it.
One ST0 to rule them all? One PE viewer to find them!
One ST_kRO to bring them all and in the darkness bind them...
Mount Doom awaits us, fellowship of OpenKore!
kLabMouse
Administrator
Posts: 1301 Joined: 24 Apr 2008, 12:02
#7
Post
by kLabMouse » 19 May 2010, 10:09
OK.So we disable "Skill_Name (HANDLE)" as that makes troubles, and it's nonsense to use it.
only left "Skill_Name" or "HANDLE".
Same go for Statuses.